Bug 185926 – Fix Issues with Loupe Gesture

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Fix Issues with Loupe Gesture

[Megan Gardner]

Created attachment 341146 [details]
Patch

[Megan Gardner]

<rdar://problem/40275709>

[Tim Horton]

Comment on attachment 341146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341146&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3212
> +#if ENABLE(MINIMAL_SIMULATOR)
> +    if (!range)
> +        [self clearSelection];
> +#endif
>      if (hasAssistedNode(_assistedNodeInformation) && !range)

Possibly(?) better written

if (range)
    return;

#if !ENABLE(MINIMAL_SIMULATOR)
if (!hasAssistedNode(_assistedNodeInformation))
    return;
#endif

[self clearSelection];

> Source/WebKit/WebProcess/WebPage/WebPage.h:1545
>  #endif
> +    
> +#if PLATFORM(IOS)

Merge these sections

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1147
> +                if (range->collapsed())

I’m pretty sure there’s a better way to do this (to sort two positions)

[Megan Gardner]

Created attachment 341157 [details]
Patch

[Wenson Hsieh]

Comment on attachment 341157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341157&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3213
> +    if (hasAssistedNode(_assistedNodeInformation))

I agree with Tim's earlier comment. It's a bit weird that we'd need to clear selection twice here in minimal simulator mode, if we are focusing an editable element.

[Megan Gardner]

Created attachment 341197 [details]
Patch

[Tim Horton]

Comment on attachment 341197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341197&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3212
>          [self clearSelection];

You’re still repeating yourself with the clearSelection! Mine was better :P

[Megan Gardner]

Created attachment 341222 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 341222 [details]
Patch for landing

Clearing flags on attachment: 341222

Committed r232164: <https://trac.webkit.org/changeset/232164>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.