NEW 185925
OSBuildFetcher should respect maxRevision while finding OS builds to report. 
https://bugs.webkit.org/show_bug.cgi?id=185925
Summary OSBuildFetcher should respect maxRevision while finding OS builds to report.
dewei_zhu
Reported 2018-05-23 16:26:38 PDT
OSBuildFetcher should respect maxRevision while finding OS builds to report.
Attachments
Patch (25.11 KB, patch)
2018-05-23 16:59 PDT, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2018-05-23 16:59:23 PDT
Created attachment 341148 [details] Patch
Ryosuke Niwa
Comment 2 2018-05-23 17:08:44 PDT
Comment on attachment 341148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341148&action=review > Websites/perf.webkit.org/tools/js/os-build-fetcher.js:101 > - .filter((commit) => commit['order'] > minOrder); > + .filter((commit) => commit['order'] > minOrder && commit['order'] < maxOrder); It seems that minOrder & maxOrder should be inclusive.
dewei_zhu
Comment 3 2018-05-23 17:11:02 PDT
Comment on attachment 341148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341148&action=review >> Websites/perf.webkit.org/tools/js/os-build-fetcher.js:101 >> + .filter((commit) => commit['order'] > minOrder && commit['order'] < maxOrder); > > It seems that minOrder & maxOrder should be inclusive. For minOrder, it should be exclusive as it is from 'last-reported' api and we don't want to report 'last-reported' again. For maxOrder, it could be both either way.
Note You need to log in before you can comment on or make changes to this bug.