Bug 185925 - OSBuildFetcher should respect maxRevision while finding OS builds to report.
Summary: OSBuildFetcher should respect maxRevision while finding OS builds to report.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-23 16:26 PDT by dewei_zhu
Modified: 2018-05-23 17:11 PDT (History)
2 users (show)

See Also:

Attachments
Patch (25.11 KB, patch)
2018-05-23 16:59 PDT, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2018-05-23 16:26:38 PDT 
OSBuildFetcher should respect maxRevision while finding OS builds to report.
Comment 1 dewei_zhu 2018-05-23 16:59:23 PDT 
Created attachment 341148 [details]
Patch
Comment 2 Ryosuke Niwa 2018-05-23 17:08:44 PDT 
Comment on attachment 341148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341148&action=review

> Websites/perf.webkit.org/tools/js/os-build-fetcher.js:101
> -                .filter((commit) => commit['order'] > minOrder);
> +                .filter((commit) => commit['order'] > minOrder && commit['order'] < maxOrder);

It seems that minOrder & maxOrder should be inclusive.
Comment 3 dewei_zhu 2018-05-23 17:11:02 PDT 
Comment on attachment 341148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341148&action=review

>> Websites/perf.webkit.org/tools/js/os-build-fetcher.js:101
>> +                .filter((commit) => commit['order'] > minOrder && commit['order'] < maxOrder);
> 
> It seems that minOrder & maxOrder should be inclusive.

For minOrder, it should be exclusive as it is from 'last-reported' api and we don't want to report 'last-reported' again. For maxOrder, it could be both either way.