RESOLVED FIXED 185923
InPlaceAbstractState should filter variables at the tail from a GetLocal by their flush format 
https://bugs.webkit.org/show_bug.cgi?id=185923
Summary InPlaceAbstractState should filter variables at the tail from a GetLocal by t...
Keith Miller
Reported 2018-05-23 15:22:14 PDT
InPlaceAbstractState should filter variables at the tail from a GetLocal by their flush format
Attachments
Patch (2.97 KB, patch)
2018-05-23 15:28 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (3.46 KB, patch)
2018-05-23 15:58 PDT, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-05-23 15:28:26 PDT
Created attachment 341136 [details] Patch
Keith Miller
Comment 2 2018-05-23 15:58:43 PDT
Created attachment 341140 [details] Patch
Saam Barati
Comment 3 2018-05-23 16:00:16 PDT
Comment on attachment 341140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341140&action=review r=me > Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:251 > + // format says it will be. The value may claim to have changed abstract state > + // but it's type from abstract state. For example: This sentence doesn't make sense: "The value may claim to have changed abstract state but it's type from abstract state"
Keith Miller
Comment 4 2018-05-23 16:03:10 PDT
Comment on attachment 341140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341140&action=review >> Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:251 >> + // but it's type from abstract state. For example: > > This sentence doesn't make sense: > "The value may claim to have changed abstract state but it's type from abstract state" Whoops, That should say: "The value may claim to have changed abstract state but it's type cannot change without a store."
Keith Miller
Comment 5 2018-05-23 16:05:03 PDT
Committed r232134: <https://trac.webkit.org/changeset/232134>
Radar WebKit Bug Importer
Comment 6 2018-05-23 16:27:47 PDT
<rdar://problem/40503241>
Saam Barati
Comment 7 2018-05-23 18:19:36 PDT
(In reply to Keith Miller from comment #4) > Comment on attachment 341140 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341140&action=review > > >> Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:251 > >> + // but it's type from abstract state. For example: > > > > This sentence doesn't make sense: > > "The value may claim to have changed abstract state but it's type from abstract state" > > Whoops, That should say: "The value may claim to have changed abstract state > but it's type cannot change without a store." “it’s type” => “its type”
Note You need to log in before you can comment on or make changes to this bug.