WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
185922
date-format-xparb spends an awful lot of time doing fmod inside JSC::msToGregorianDateTime
https://bugs.webkit.org/show_bug.cgi?id=185922
Summary
date-format-xparb spends an awful lot of time doing fmod inside JSC::msToGreg...
Filip Pizlo
Reported
2018-05-23 14:18:31 PDT
It seems like the repeat fmod calls could be avoided if we did all of the to-seconds/to-minutes/to-hours conversions as part of one inlined math formula. For example, if we extract the hours component as a double, and then floor it, then we could extract the minutes without having to do an fmod: we'd just extract the fractional part dropped by the floor and multiply by 60.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug