Bug 185914 - Speed up JetStream/base64
Summary: Speed up JetStream/base64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-23 07:40 PDT by Filip Pizlo
Modified: 2018-05-23 15:46 PDT (History)
3 users (show)

See Also:


Attachments
the patch (20.26 KB, patch)
2018-05-23 07:42 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (21.94 KB, patch)
2018-05-23 12:27 PDT, Filip Pizlo
msaboff: review+
Details | Formatted Diff | Diff
patch for landing (22.93 KB, patch)
2018-05-23 13:44 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
patch for landing (23.42 KB, patch)
2018-05-23 14:05 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-05-23 07:40:33 PDT
While profiling base64, I found that:

- It really wanted allocation paths to be inline in C++ code.
- Rope string resolution was spending a lot of time calling Vector<>::append because it wasn't inlined.
Comment 1 Filip Pizlo 2018-05-23 07:42:03 PDT
Created attachment 341091 [details]
the patch
Comment 2 EWS Watchlist 2018-05-23 07:45:09 PDT
Attachment 341091 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSCellInlines.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2018-05-23 12:27:43 PDT
Created attachment 341116 [details]
the patch
Comment 4 Michael Saboff 2018-05-23 12:29:40 PDT
Comment on attachment 341116 [details]
the patch

r=me
Nice!
Comment 5 EWS Watchlist 2018-05-23 12:30:33 PDT
Attachment 341116 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSCellInlines.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Filip Pizlo 2018-05-23 13:44:42 PDT
Created attachment 341125 [details]
patch for landing
Comment 7 EWS Watchlist 2018-05-23 13:47:01 PDT
Attachment 341125 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSCellInlines.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2018-05-23 14:05:35 PDT
Created attachment 341127 [details]
patch for landing
Comment 9 EWS Watchlist 2018-05-23 14:07:15 PDT
Attachment 341127 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSCellInlines.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Filip Pizlo 2018-05-23 15:34:34 PDT
Landed in https://trac.webkit.org/changeset/232132/webkit
Comment 11 Radar WebKit Bug Importer 2018-05-23 15:46:19 PDT
<rdar://problem/40501797>