Bug 185898 - [LFC] Move sizing/positioning logic to helper classes
Summary: [LFC] Move sizing/positioning logic to helper classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-22 19:21 PDT by zalan
Modified: 2018-05-23 09:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (85.62 KB, patch)
2018-05-22 20:24 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (90.02 KB, patch)
2018-05-23 09:17 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-05-22 19:21:55 PDT 
with static functions.
Comment 1 zalan 2018-05-22 20:24:55 PDT 
Created attachment 341064 [details]
Patch
Comment 2 zalan 2018-05-22 20:37:40 PDT 
Not sure about the class names though. Suggestions are welcome!
Comment 3 Antti Koivisto 2018-05-23 07:21:35 PDT 
Comment on attachment 341064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341064&action=review

> Source/WebCore/layout/FormattingContext.cpp:66
> +        computedTopLeft = FormattingContextGeometry::outOfFlowReplacedPosition(layoutContext, layoutBox);

Maybe FormattingContextGeometry could be an inner class of FormattingContext (FormattingContext::Geometry)?

This way you could just write Geometry::outOfFlowReplacedPosition(...) here.
Comment 4 zalan 2018-05-23 09:17:16 PDT 
Created attachment 341096 [details]
Patch
Comment 5 zalan 2018-05-23 09:17:34 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 341064 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341064&action=review
> 
> > Source/WebCore/layout/FormattingContext.cpp:66
> > +        computedTopLeft = FormattingContextGeometry::outOfFlowReplacedPosition(layoutContext, layoutBox);
> 
> Maybe FormattingContextGeometry could be an inner class of FormattingContext
> (FormattingContext::Geometry)?
> 
> This way you could just write Geometry::outOfFlowReplacedPosition(...) here.
Good point!
Comment 6 WebKit Commit Bot 2018-05-23 09:56:18 PDT 
Comment on attachment 341096 [details]
Patch

Clearing flags on attachment: 341096

Committed r232114: <https://trac.webkit.org/changeset/232114>
Comment 7 WebKit Commit Bot 2018-05-23 09:56:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-05-23 09:57:22 PDT 
<rdar://problem/40488646>