Bug 185898 – [LFC] Move sizing/positioning logic to helper classes

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

with static functions.

[zalan]

Created attachment 341064 [details]
Patch

[zalan]

Not sure about the class names though. Suggestions are welcome!

[Antti Koivisto]

Comment on attachment 341064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341064&action=review

> Source/WebCore/layout/FormattingContext.cpp:66
> +        computedTopLeft = FormattingContextGeometry::outOfFlowReplacedPosition(layoutContext, layoutBox);

Maybe FormattingContextGeometry could be an inner class of FormattingContext (FormattingContext::Geometry)?

This way you could just write Geometry::outOfFlowReplacedPosition(...) here.

[zalan]

Created attachment 341096 [details]
Patch

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 341064 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341064&action=review
> 
> > Source/WebCore/layout/FormattingContext.cpp:66
> > +        computedTopLeft = FormattingContextGeometry::outOfFlowReplacedPosition(layoutContext, layoutBox);
> 
> Maybe FormattingContextGeometry could be an inner class of FormattingContext
> (FormattingContext::Geometry)?
> 
> This way you could just write Geometry::outOfFlowReplacedPosition(...) here.
Good point!

[WebKit Commit Bot]

Comment on attachment 341096 [details]
Patch

Clearing flags on attachment: 341096

Committed r232114: <https://trac.webkit.org/changeset/232114>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40488646>