Bug 185888 - StringImpl utf8 conversion should not fail silently.
Summary: StringImpl utf8 conversion should not fail silently.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on:
Reported: 2018-05-22 14:30 PDT by Mark Lam
Modified: 2018-05-23 05:37 PDT (History)
7 users (show)

See Also:

proposed patch. (24.65 KB, patch)
2018-05-22 15:09 PDT, Mark Lam
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-05-22 14:30:19 PDT
Patch coming.
Comment 1 Radar WebKit Bug Importer 2018-05-22 14:31:03 PDT
Comment 2 Mark Lam 2018-05-22 15:09:42 PDT
Created attachment 341035 [details]
proposed patch.
Comment 3 Mark Lam 2018-05-22 16:55:01 PDT
Thanks for the review.  Landed in r232089: <http://trac.webkit.org/r232089>.
Comment 4 Alexey Proskuryakov 2018-05-22 18:54:49 PDT
Comment on attachment 341035 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=341035&action=review

> Source/WTF/wtf/text/WTFString.cpp:820
> +    RELEASE_ASSERT(expectedString);

Did we really never ever check the result in callers? If we did, those checks need to be removed now.
Comment 5 Yusuke Suzuki 2018-05-23 05:37:20 PDT
Committed r232108: <https://trac.webkit.org/changeset/232108>