RESOLVED FIXED185888
StringImpl utf8 conversion should not fail silently. 
https://bugs.webkit.org/show_bug.cgi?id=185888
Summary StringImpl utf8 conversion should not fail silently.
Mark Lam
Reported 2018-05-22 14:30:19 PDT
Patch coming.
Attachments
proposed patch. (24.65 KB, patch)
2018-05-22 15:09 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-22 14:31:03 PDT
<rdar://problem/40464506>
Mark Lam
Comment 2 2018-05-22 15:09:42 PDT
Created attachment 341035 [details] proposed patch.
Mark Lam
Comment 3 2018-05-22 16:55:01 PDT
Thanks for the review. Landed in r232089: <http://trac.webkit.org/r232089>.
Alexey Proskuryakov
Comment 4 2018-05-22 18:54:49 PDT
Comment on attachment 341035 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=341035&action=review > Source/WTF/wtf/text/WTFString.cpp:820 > + RELEASE_ASSERT(expectedString); Did we really never ever check the result in callers? If we did, those checks need to be removed now.
Yusuke Suzuki
Comment 5 2018-05-23 05:37:20 PDT
Committed r232108: <https://trac.webkit.org/changeset/232108>
Note You need to log in before you can comment on or make changes to this bug.