Bug 185885 – Setting drawsBackground to YES on a WKView doesn't take effect immediately

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Timothy Hatcher]

<rdar://problem/39706506>

[Timothy Hatcher]

Created attachment 341024 [details]
Patch

[EWS Watchlist]

Comment on attachment 341024 [details]
Patch

Attachment 341024 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7769488

New failing tests:
fast/borders/border-radius-on-html.html
css3/blending/blend-mode-html-element-screen.html

[EWS Watchlist]

Created attachment 341037 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341024 [details]
Patch

Attachment 341024 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7769720

New failing tests:
fast/borders/border-radius-on-html.html
css3/blending/blend-mode-html-element-screen.html

[EWS Watchlist]

Created attachment 341039 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Timothy Hatcher]

(In reply to Build Bot from comment #2)
> Comment on attachment 341024 [details]
> Patch
> 
> Attachment 341024 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/7769488
> 
> New failing tests:
> fast/borders/border-radius-on-html.html
> css3/blending/blend-mode-html-element-screen.html

These tests fail for me without my patch. Hmm.

[Timothy Hatcher]

Created attachment 341103 [details]
Patch

[Timothy Hatcher]

Comment on attachment 341103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341103&action=review

> Source/WebCore/ChangeLog:24
> +        instead of hadcoding white.

Typo, will fix.

[Simon Fraser (smfr)]

Comment on attachment 341103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341103&action=review

> Source/WebCore/page/FrameView.cpp:2938
> +            if (view->needsLayout())
> +                view->layoutContext().scheduleLayout();

It's sad that you have to do this.

[Timothy Hatcher]

Created attachment 341107 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 341107 [details]
Patch

Rejecting attachment 341107 [details] from commit-queue.

New failing tests:
fast/borders/border-radius-on-html.html
css3/blending/blend-mode-html-element-screen.html
Full output: http://webkit-queues.webkit.org/results/7779151

[WebKit Commit Bot]

Created attachment 341112 [details]
Archive of layout-test-results from webkit-cq-01 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Timothy Hatcher]

Created attachment 341351 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 341351 [details]
Patch

Clearing flags on attachment: 341351

Committed r232218: <https://trac.webkit.org/changeset/232218>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.