Bug 185865 – Fix build without MathML

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Olivier Blin]

Build without ENABLE(MATHML) fails.

Regression(r226654): [RenderTreeBuilder] Move MathML addChild logic to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181443

Regression(r229694): Put the DOM in IsoHeaps
https://bugs.webkit.org/show_bug.cgi?id=183546

[Olivier Blin]

Created attachment 340976 [details]
Patch

[Olivier Blin]

You may want to know if it is still worth maintaining this MathML build flag.

On an ARMv7 platform, disabling MathML allows to save 242,148 bytes over a library of 27,063,644 bytes, that's about 1% of the size.

[Michael Catanzaro]

Comment on attachment 340976 [details]
Patch

Sigh, I think it's OK even without exposing the MATHML build flag for WPE, because none of the code is platform-specific.

[Michael Catanzaro]

(In reply to Olivier Blin from comment #2)
> You may want to know if it is still worth maintaining this MathML build flag.
> 
> On an ARMv7 platform, disabling MathML allows to save 242,148 bytes over a
> library of 27,063,644 bytes, that's about 1% of the size.

And yes, if you didn't have this analysis to prove it's significant, we would have probably started to talk about that.

[WebKit Commit Bot]

Comment on attachment 340976 [details]
Patch

Clearing flags on attachment: 340976

Committed r232064: <https://trac.webkit.org/changeset/232064>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40450626>