Bug 185853 – Add notifyutil callbacks to dump the memory cache, and the list of live Pages and Documents

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Add notifyutil callbacks to dump the memory cache, and the list of live Pages and Documents

[Simon Fraser (smfr)]

Created attachment 340930 [details]
Patch

[EWS Watchlist]

Attachment 340930 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/PageMac.mm:81:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Keith Miller]

Comment on attachment 340930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340930&action=review

r=me. Seems reasonable.

> Source/WebCore/ChangeLog:11
> +        Document pointer address and URL.

Maybe it's worth putting a brief example of how to use notifyutil on MacOS? For those of us unsure of exactly how to do it... e.g. me >.>

[Simon Fraser (smfr)]

Created attachment 341029 [details]
Patch

[EWS Watchlist]

Attachment 341029 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/PageMac.mm:81:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 341029 [details]
Patch

Attachment 341029 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7770041

New failing tests:
imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-020.html

[EWS Watchlist]

Created attachment 341043 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Simon Fraser (smfr)]

Created attachment 341044 [details]
Patch

[EWS Watchlist]

Attachment 341044 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/PageMac.mm:81:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 341044 [details]
Patch

Clearing flags on attachment: 341044

Committed r232098: <https://trac.webkit.org/changeset/232098>

[Chris Dumez]

Comment on attachment 341044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341044&action=review

> Source/WebCore/loader/cache/MemoryCache.cpp:336
> +            WTFLogAlways("pruneLiveResourcesToSize: trying to prune %p", current);

Did you mean to keep this in? I see this in my terminal all the time now.

[Simon Fraser (smfr)]

I did not, sorry. I'll remove it.

[Simon Fraser (smfr)]

> > Source/WebCore/loader/cache/MemoryCache.cpp:336
> > +            WTFLogAlways("pruneLiveResourcesToSize: trying to prune %p", current);
> 
> Did you mean to keep this in? I see this in my terminal all the time now.

Removed in r232597

[Radar WebKit Bug Importer]

<rdar://problem/40920513>