Bug 185835 - Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
Summary: Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-21 13:38 PDT by Sihui Liu
Modified: 2018-05-29 09:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2018-05-21 13:54 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (5.10 KB, patch)
2018-05-22 14:42 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (5.14 KB, patch)
2018-05-28 23:05 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2018-05-28 23:08 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-05-21 13:38:07 PDT 
Using removeDataOfType to clear all data of specific origins would fail to delete IndexedDB database files.
Comment 1 Sihui Liu 2018-05-21 13:45:52 PDT 
<rdar://problem/39142257>
Comment 2 Sihui Liu 2018-05-21 13:54:17 PDT 
Created attachment 340883 [details]
Patch
Comment 3 Geoffrey Garen 2018-05-21 14:00:24 PDT 
Can you add an API test for this?

We generally require a regression test for all behavior changes. This seems to be a case where the test truly is more valuable than the code, since the mistake in the code was so basic.
Comment 4 Brady Eidson 2018-05-21 14:28:48 PDT 
Comment on attachment 340883 [details]
Patch

I'll go farther than Geoff and say r- until there's a test
Comment 5 Sihui Liu 2018-05-22 14:42:08 PDT 
Created attachment 341030 [details]
Patch
Comment 6 Sihui Liu 2018-05-28 23:05:43 PDT 
Created attachment 341474 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-05-28 23:06:40 PDT 
Comment on attachment 341474 [details]
Patch for landing

Rejecting attachment 341474 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 341474, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/7842096
Comment 8 Sihui Liu 2018-05-28 23:08:56 PDT 
Created attachment 341475 [details]
Patch
Comment 9 WebKit Commit Bot 2018-05-29 09:12:28 PDT 
Comment on attachment 341475 [details]
Patch

Clearing flags on attachment: 341475

Committed r232258: <https://trac.webkit.org/changeset/232258>
Comment 10 WebKit Commit Bot 2018-05-29 09:12:29 PDT 
All reviewed patches have been landed.  Closing bug.