WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
185826
Add a diskCacheSizeOverride accessor function on WKContextConfigurationRef
https://bugs.webkit.org/show_bug.cgi?id=185826
Summary
Add a diskCacheSizeOverride accessor function on WKContextConfigurationRef
Sihui Liu
Reported
2018-05-21 11:48:39 PDT
Required for <
rdar://problem/39432656
>.
Attachments
Patch
(2.66 KB, patch)
2018-05-21 11:59 PDT
,
Sihui Liu
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sihui Liu
Comment 1
2018-05-21 11:49:21 PDT
<
rdar://problem/39732113
>
Sihui Liu
Comment 2
2018-05-21 11:59:05 PDT
Created
attachment 340868
[details]
Patch
Chris Dumez
Comment 3
2018-05-21 12:29:14 PDT
Comment on
attachment 340868
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=340868&action=review
> Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:83 > +WK_EXPORT int64_t WKContextConfigurationDiskCacheSizeOverride(WKContextConfigurationRef configuration);
Is there an equivalent Cocoa API / SPI already? We are not supposed to add any new C API without a Cocoa equivalent.
Sihui Liu
Comment 4
2018-05-21 13:28:58 PDT
(In reply to Chris Dumez from
comment #3
)
> Comment on
attachment 340868
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=340868&action=review
> > > Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:83 > > +WK_EXPORT int64_t WKContextConfigurationDiskCacheSizeOverride(WKContextConfigurationRef configuration); > > Is there an equivalent Cocoa API / SPI already? We are not supposed to add > any new C API without a Cocoa equivalent.
There is diskCacheSizeOverride in API/Cocoa/_WKProcessPoolConfiguration.h.
Chris Dumez
Comment 5
2018-05-21 13:30:57 PDT
(In reply to Sihui Liu from
comment #4
)
> (In reply to Chris Dumez from
comment #3
) > > Comment on
attachment 340868
[details]
> > Patch > > > > View in context: > >
https://bugs.webkit.org/attachment.cgi?id=340868&action=review
> > > > > Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:83 > > > +WK_EXPORT int64_t WKContextConfigurationDiskCacheSizeOverride(WKContextConfigurationRef configuration); > > > > Is there an equivalent Cocoa API / SPI already? We are not supposed to add > > any new C API without a Cocoa equivalent. > > There is diskCacheSizeOverride in API/Cocoa/_WKProcessPoolConfiguration.h.
Great, thanks.
WebKit Commit Bot
Comment 6
2018-05-21 13:57:57 PDT
Comment on
attachment 340868
[details]
Patch Clearing flags on attachment: 340868 Committed
r232025
: <
https://trac.webkit.org/changeset/232025
>
WebKit Commit Bot
Comment 7
2018-05-21 13:57:58 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug