Bug 185824 - [WPE][WebDriver] add ICU include dirs
Summary: [WPE][WebDriver] add ICU include dirs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-21 10:30 PDT by Olivier Blin
Modified: 2018-05-21 11:18 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2018-05-21 10:32 PDT, Olivier Blin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2018-05-21 10:30:35 PDT
WebDriver does not build in the WPE port when ICU headers are in a non-default directory.
Comment 1 Olivier Blin 2018-05-21 10:32:06 PDT
Created attachment 340861 [details]
Patch
Comment 2 Olivier Blin 2018-05-21 10:34:23 PDT
Comment on attachment 340861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340861&action=review

> Source/WebDriver/PlatformWPE.cmake:5
> +    "${ICU_INCLUDE_DIRS}"

Is this the best place to put this since ICU is common to all ports?
Shouldn't this be inherited from WTF?
Comment 3 Konstantin Tokarev 2018-05-21 10:39:05 PDT
Comment on attachment 340861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340861&action=review

>> Source/WebDriver/PlatformWPE.cmake:5
>> +    "${ICU_INCLUDE_DIRS}"
> 
> Is this the best place to put this since ICU is common to all ports?
> Shouldn't this be inherited from WTF?

It was once working like this, but is not the case since https://bugs.webkit.org/show_bug.cgi?id=181656
Comment 4 WebKit Commit Bot 2018-05-21 11:17:42 PDT
Comment on attachment 340861 [details]
Patch

Clearing flags on attachment: 340861

Committed r232022: <https://trac.webkit.org/changeset/232022>
Comment 5 WebKit Commit Bot 2018-05-21 11:17:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-05-21 11:18:18 PDT
<rdar://problem/40422734>