Bug 185822 - Propagate WebCore system include dirs in WebCoreHeaderInterface
Summary: Propagate WebCore system include dirs in WebCoreHeaderInterface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-21 10:05 PDT by Olivier Blin
Modified: 2018-05-21 10:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2018-05-21 10:07 PDT, Olivier Blin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2018-05-21 10:05:16 PDT
System include directories from WebCore are not propagated anymore to its users.
For example gcrypt, sqlite and ICU system headers defined in PAL are not properly passed to WebKit build.

This may have been caused partly by the fix in r230385: [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
https://bugs.webkit.org/show_bug.cgi?id=184127
Comment 1 Olivier Blin 2018-05-21 10:07:07 PDT
Created attachment 340857 [details]
Patch
Comment 2 WebKit Commit Bot 2018-05-21 10:52:24 PDT
Comment on attachment 340857 [details]
Patch

Clearing flags on attachment: 340857

Committed r232020: <https://trac.webkit.org/changeset/232020>
Comment 3 WebKit Commit Bot 2018-05-21 10:52:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-05-21 10:53:25 PDT
<rdar://problem/40421553>