WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
185822
Propagate WebCore system include dirs in WebCoreHeaderInterface
https://bugs.webkit.org/show_bug.cgi?id=185822
Summary
Propagate WebCore system include dirs in WebCoreHeaderInterface
Olivier Blin
Reported
2018-05-21 10:05:16 PDT
System include directories from WebCore are not propagated anymore to its users. For example gcrypt, sqlite and ICU system headers defined in PAL are not properly passed to WebKit build. This may have been caused partly by the fix in
r230385
: [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
https://bugs.webkit.org/show_bug.cgi?id=184127
Attachments
Patch
(1.67 KB, patch)
2018-05-21 10:07 PDT
,
Olivier Blin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Olivier Blin
Comment 1
2018-05-21 10:07:07 PDT
Created
attachment 340857
[details]
Patch
WebKit Commit Bot
Comment 2
2018-05-21 10:52:24 PDT
Comment on
attachment 340857
[details]
Patch Clearing flags on attachment: 340857 Committed
r232020
: <
https://trac.webkit.org/changeset/232020
>
WebKit Commit Bot
Comment 3
2018-05-21 10:52:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4
2018-05-21 10:53:25 PDT
<
rdar://problem/40421553
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug