Bug 185821 - Fix FrameLoader build without video
Summary: Fix FrameLoader build without video
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-21 09:52 PDT by Olivier Blin
Modified: 2018-05-21 10:52 PDT (History)
11 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2018-05-21 09:56 PDT, Olivier Blin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2018-05-21 09:52:37 PDT
Regression(r231392): Release assert in ScriptController::canExecuteScripts via HTMLMediaElement::~HTMLMediaElement()
https://bugs.webkit.org/show_bug.cgi?id=185288

../../Source/WebCore/loader/FrameLoader.cpp:818:9: error: incomplete type 'WebCore::HTMLMediaElement' named in nested name specifier
    if (HTMLMediaElement::isRunningDestructor()) {
        ^~~~~~~~~~~~~~~~~~
../../Source/WebCore/dom/Document.h:130:7: note: forward declaration of 'WebCore::HTMLMediaElement'
Comment 1 Olivier Blin 2018-05-21 09:56:00 PDT
Created attachment 340855 [details]
Patch
Comment 2 WebKit Commit Bot 2018-05-21 10:50:09 PDT
Comment on attachment 340855 [details]
Patch

Clearing flags on attachment: 340855

Committed r232019: <https://trac.webkit.org/changeset/232019>
Comment 3 WebKit Commit Bot 2018-05-21 10:50:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-05-21 10:52:51 PDT
<rdar://problem/40421514>