Bug 185813 - [JSC] Remove duplicate methods in JSInterfaceJIT
Summary: [JSC] Remove duplicate methods in JSInterfaceJIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-20 23:00 PDT by Yusuke Suzuki
Modified: 2018-05-21 22:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (28.90 KB, patch)
2018-05-20 23:01 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (29.92 KB, patch)
2018-05-21 05:55 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (29.81 KB, patch)
2018-05-21 06:13 PDT, Yusuke Suzuki 		sbarati: review+
Details | Formatted Diff | Diff
Patch for landing (29.07 KB, patch)
2018-05-21 22:14 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-05-20 23:00:16 PDT 
[JSC] Remove duplicate methods in JSInterfaceJIT
Comment 1 Yusuke Suzuki 2018-05-20 23:01:02 PDT 
Created attachment 340828 [details]
Patch
Comment 2 Yusuke Suzuki 2018-05-21 05:55:57 PDT 
Created attachment 340843 [details]
Patch
Comment 3 Yusuke Suzuki 2018-05-21 06:13:19 PDT 
Created attachment 340846 [details]
Patch
Comment 4 Saam Barati 2018-05-21 17:21:34 PDT 
Comment on attachment 340846 [details]
Patch

r=me if 32-bit is working
Comment 5 Yusuke Suzuki 2018-05-21 22:14:46 PDT 
Created attachment 340955 [details]
Patch for landing
Comment 6 Yusuke Suzuki 2018-05-21 22:16:39 PDT 
Comment on attachment 340846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340846&action=review

> Source/JavaScriptCore/jit/ThunkGenerators.cpp:382
> +    JSInterfaceJIT::Jump exceptionHandler = jit.branchTestPtr(JSInterfaceJIT::NonZero, JSInterfaceJIT::AbsoluteAddress(vm->addressOfException()));

Oh, we do not have branchTestPtr(cond, AbsoluteAddress) for 32bit...
Comment 7 Yusuke Suzuki 2018-05-21 22:46:33 PDT 
Committed r232048: <https://trac.webkit.org/changeset/232048>
Comment 8 Radar WebKit Bug Importer 2018-05-21 22:47:19 PDT 
<rdar://problem/40441671>