RESOLVED FIXED 185810
[JSC] Use branchIfString/branchIfNotString instead of structure checkings 
https://bugs.webkit.org/show_bug.cgi?id=185810
Summary [JSC] Use branchIfString/branchIfNotString instead of structure checkings
Yusuke Suzuki
Reported 2018-05-20 21:32:07 PDT
[JSC] Use branchIfString/branchIfNotString instead of structure checkings
Attachments
Patch (15.27 KB, patch)
2018-05-20 21:39 PDT, Yusuke Suzuki 		saam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.84 MB, application/zip)
2018-05-22 00:28 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-20 21:39:55 PDT
Created attachment 340821 [details] Patch
EWS Watchlist
Comment 2 2018-05-22 00:28:33 PDT
Comment on attachment 340821 [details] Patch Attachment 340821 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7761860 New failing tests: http/tests/preload/onload_event.html
EWS Watchlist
Comment 3 2018-05-22 00:28:44 PDT
Created attachment 340959 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Saam Barati
Comment 4 2018-05-22 21:01:04 PDT
Comment on attachment 340821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340821&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + it emits less code since we do not need to embed string structure's We would only embed this on 32-bit.
Yusuke Suzuki
Comment 5 2018-05-22 21:42:50 PDT
Comment on attachment 340821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340821&action=review >> Source/JavaScriptCore/ChangeLog:10 >> + it emits less code since we do not need to embed string structure's > > We would only embed this on 32-bit. Yeah, we emit structure id :)
Yusuke Suzuki
Comment 6 2018-05-22 21:44:49 PDT
Committed r232105: <https://trac.webkit.org/changeset/232105>
Radar WebKit Bug Importer
Comment 7 2018-05-22 21:46:21 PDT
<rdar://problem/40475347>
Note You need to log in before you can comment on or make changes to this bug.