Bug 185810 - [JSC] Use branchIfString/branchIfNotString instead of structure checkings
Summary: [JSC] Use branchIfString/branchIfNotString instead of structure checkings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-20 21:32 PDT by Yusuke Suzuki
Modified: 2018-05-22 21:46 PDT (History)
6 users (show)

See Also:


Attachments
Patch (15.27 KB, patch)
2018-05-20 21:39 PDT, Yusuke Suzuki
sbarati: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (12.84 MB, application/zip)
2018-05-22 00:28 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-05-20 21:32:07 PDT
[JSC] Use branchIfString/branchIfNotString instead of structure checkings
Comment 1 Yusuke Suzuki 2018-05-20 21:39:55 PDT
Created attachment 340821 [details]
Patch
Comment 2 EWS Watchlist 2018-05-22 00:28:33 PDT
Comment on attachment 340821 [details]
Patch

Attachment 340821 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7761860

New failing tests:
http/tests/preload/onload_event.html
Comment 3 EWS Watchlist 2018-05-22 00:28:44 PDT
Created attachment 340959 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Saam Barati 2018-05-22 21:01:04 PDT
Comment on attachment 340821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340821&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +        it emits less code since we do not need to embed string structure's

We would only embed this on 32-bit.
Comment 5 Yusuke Suzuki 2018-05-22 21:42:50 PDT
Comment on attachment 340821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340821&action=review

>> Source/JavaScriptCore/ChangeLog:10
>> +        it emits less code since we do not need to embed string structure's
> 
> We would only embed this on 32-bit.

Yeah, we emit structure id :)
Comment 6 Yusuke Suzuki 2018-05-22 21:44:49 PDT
Committed r232105: <https://trac.webkit.org/changeset/232105>
Comment 7 Radar WebKit Bug Importer 2018-05-22 21:46:21 PDT
<rdar://problem/40475347>