Bug 185779 – Handle failure to extend sandbox gracefully

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Eric Carlson]

Handle failure to extend sandbox gracefully

[Eric Carlson]

<rdar://problem/40316349>

[Eric Carlson]

Created attachment 340729 [details]
Patch

[Brent Fulgham]

Comment on attachment 340729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340729&action=review

Looks great! r=me

> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:186
> +    UNUSED_PARAM(proxy);

You probably don't need UNUSED_PARAM here, since proxy is used below.

[WebKit Commit Bot]

Comment on attachment 340729 [details]
Patch

Clearing flags on attachment: 340729

Committed r231979: <https://trac.webkit.org/changeset/231979>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Dawei Fenton (:realdawei)]

The API test added with this change is failing regularly: MediaCaptureSimulateFailedSandbox.Test

https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/5462/steps/run-api-tests/logs/stdio

 /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:139
        Value of: "AbortError,Unable to extend sandbox"
        Expected: [error UTF8String]
        Which is: "AbortError,Unable to extend sandbox."

[Eric Carlson]

Reopening to attach new patch.

[Eric Carlson]

Created attachment 340743 [details]
Fix test results

[WebKit Commit Bot]

Comment on attachment 340743 [details]
Fix test results

Clearing flags on attachment: 340743

Committed r231992: <https://trac.webkit.org/changeset/231992>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.