Bug 185776 - build-webkit: Perl "use of uninitialized value $previousContents"
Summary: build-webkit: Perl "use of uninitialized value $previousContents"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: PC Other
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 182575
  Show dependency tree / graph
 
Reported: 2018-05-18 11:52 PDT by Daniel Bates
Modified: 2018-06-29 19:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2018-05-18 11:57 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-05-18 11:52:16 PDT 
When looking at <https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/841/steps/compile-webkit/logs/stdio> I noticed the following Perl warnings:

[[
perl ./Tools/Scripts/build-webkit --debug --wincairo
...
Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969.
Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972.
[0/219] Generate bindings (WebCoreBindings)
...
]]
Comment 1 Daniel Bates 2018-05-18 11:54:56 PDT 
These warnings means that the specified file passed to isCachedArgumentfileOutOfDate() is an empty file.
Comment 2 Daniel Bates 2018-05-18 11:57:58 PDT 
Created attachment 340722 [details]
Patch
Comment 3 Basuke Suzuki 2018-05-18 13:33:17 PDT 
Nice. I'm so sad my perl knowledge is so out of date that I cannot judge this fix is correct or not. This may solve an warning issue, that's good. Then it open the next door what makes this file keep being blank though.
Comment 4 Daniel Bates 2018-06-29 19:12:53 PDT 
Comment on attachment 340722 [details]
Patch

Clearing flags on attachment: 340722

Committed r233388: <https://trac.webkit.org/changeset/233388>
Comment 5 Daniel Bates 2018-06-29 19:12:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-29 19:13:15 PDT 
<rdar://problem/41663619>