Bug 185775 - Convert ProcessPrivilege assertions to regular debug-only assertions
Summary: Convert ProcessPrivilege assertions to regular debug-only assertions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 184322
Blocks:
  Show dependency tree / graph
 
Reported: 2018-05-18 11:37 PDT by Brent Fulgham
Modified: 2018-05-18 13:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (19.36 KB, patch)
2018-05-18 11:41 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-05-18 11:37:24 PDT 
In Bug 184322 I added a number of RELEASE_ASSERT checks that WindowServer-related calls were not being made in the WebContent process.

Measurements have shown that these RELEASE_ASSERTs have regressed performance by around 1% on some benchmarks, so we should convert them to normal asserts.
Comment 1 Radar WebKit Bug Importer 2018-05-18 11:40:27 PDT 
<rdar://problem/40372286>
Comment 2 Brent Fulgham 2018-05-18 11:41:53 PDT 
Created attachment 340719 [details]
Patch
Comment 3 Geoffrey Garen 2018-05-18 12:53:41 PDT 
Comment on attachment 340719 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-05-18 13:20:40 PDT 
Comment on attachment 340719 [details]
Patch

Clearing flags on attachment: 340719

Committed r231980: <https://trac.webkit.org/changeset/231980>
Comment 5 WebKit Commit Bot 2018-05-18 13:20:42 PDT 
All reviewed patches have been landed.  Closing bug.