Bug 18576 - [GTK] windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and GDK_KP_Enter
Summary: [GTK] windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and GDK_KP_Enter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-18 03:37 PDT by Marco Barisione
Modified: 2008-04-18 20:32 PDT (History)
1 user (show)

See Also:

Attachments
Handle GDK_ISO_Enter and GDK_KP_Enter in windowsKeyCodeForKeyEvent (1003 bytes, patch)
2008-04-18 04:20 PDT, Marco Barisione 		alp: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Barisione 2008-04-18 03:37:50 PDT 
windowsKeyCodeForKeyEvent (in WebCore/platform/gtk/KeyEventGtk.cpp) handles GDK_Return but not GDK_ISO_Enter and GDK_KP_Enter.

I will write a patch ASAP.
Comment 1 Marco Barisione 2008-04-18 04:20:51 PDT 
Created attachment 20663 [details]
Handle GDK_ISO_Enter and GDK_KP_Enter in windowsKeyCodeForKeyEvent
Comment 2 Alp Toker 2008-04-18 20:32:08 PDT 
Landed in r32245.

patch had a little trouble with this one so I had to hand-apply.