Bug 185755 – We don't throw SyntaxErrors for runtime generated regular expressions with errors

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

We properly handle and report syntax errors for statically declared regular expressions.  When we need to compile a regular expression as part of executing methods that take a regular we sometime don't report errors.

[Michael Saboff]

<rdar://problem/40303478>

[Michael Saboff]

Created attachment 340668 [details]
Patch

[Keith Miller]

Comment on attachment 340668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340668&action=review

r=me.

> Source/JavaScriptCore/runtime/RegExpConstructor.cpp:286
> +                throwException(exec, scope, regExp->errorToThrow(exec));

shouldn't there be a return here? Why create an invalid RegExp?

[Michael Saboff]

(In reply to Keith Miller from comment #3)
> Comment on attachment 340668 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340668&action=review
> 
> r=me.
> 
> > Source/JavaScriptCore/runtime/RegExpConstructor.cpp:286
> > +                throwException(exec, scope, regExp->errorToThrow(exec));
> 
> shouldn't there be a return here? Why create an invalid RegExp?

Sure, I'll return the exception object.

[EWS Watchlist]

Comment on attachment 340668 [details]
Patch

Attachment 340668 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7717410

New failing tests:
js/stack-overflow-regexp.html

[EWS Watchlist]

Created attachment 340669 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340668 [details]
Patch

Attachment 340668 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7717358

New failing tests:
jsc-layout-tests.yaml/js/script-tests/stack-overflow-regexp.js.layout-no-cjit
jsc-layout-tests.yaml/js/script-tests/stack-overflow-regexp.js.layout-dfg-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/stack-overflow-regexp.js.layout-no-llint
jsc-layout-tests.yaml/js/script-tests/stack-overflow-regexp.js.layout
jsc-layout-tests.yaml/js/script-tests/stack-overflow-regexp.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/stack-overflow-regexp.js.layout-no-ftl
jsc-layout-tests.yaml/js/script-tests/stack-overflow-regexp.js.layout-ftl-eager-no-cjit
apiTests

[Michael Saboff]

Created attachment 340670 [details]
Updated patch with new results for stack-overflow-regexp.js

[Keith Miller]

Comment on attachment 340670 [details]
Updated patch with new results for stack-overflow-regexp.js

r=me.

[WebKit Commit Bot]

Comment on attachment 340670 [details]
Updated patch with new results for stack-overflow-regexp.js

Clearing flags on attachment: 340670

Committed r231939: <https://trac.webkit.org/changeset/231939>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.