Bug 185753 - defaultConstructorSourceCode needs to makeSource every time it's called
Summary: defaultConstructorSourceCode needs to makeSource every time it's called
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-17 16:13 PDT by Saam Barati
Modified: 2018-05-17 16:21 PDT (History)
2 users (show)

See Also:

Attachments
patch for landing (2.27 KB, patch)
2018-05-17 16:17 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-05-17 16:13:40 PDT 
Rubber stamped already by Mark Lam.

The bug here is multiple VMs can be running concurrently to one another in the same process. They may each ref/deref something that isn't ThreadSafeRefCounted
Comment 1 Saam Barati 2018-05-17 16:17:59 PDT 
Created attachment 340664 [details]
patch for landing
Comment 2 Saam Barati 2018-05-17 16:20:45 PDT 
landed in:
https://trac.webkit.org/changeset/231930/webkit
Comment 3 Radar WebKit Bug Importer 2018-05-17 16:21:18 PDT 
<rdar://problem/40349098>