libcurl requires setup to enable HTTP/2 multiplexing in a multi handle.
Created attachment 340654 [details] Patch
Comment on attachment 340654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340654&action=review > Source/WebCore/ChangeLog:3 > + [Curl] Enable HTTP/2 Multiplexing Nice! > Source/WebCore/ChangeLog:8 > + Covered by existing tests. I do not think WebKit has HTTP/2 test infra so I guess you have your own internal tests? > Source/WebCore/platform/network/curl/CurlContext.cpp:202 > + curl_multi_setopt(m_multiHandle, CURLMOPT_PIPELINING, CURLPIPE_MULTIPLEX); Will the handle support both HTTP/2 and HTTP/1.1?
(In reply to youenn fablet from comment #2) > Comment on attachment 340654 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340654&action=review > > > Source/WebCore/ChangeLog:3 > > + [Curl] Enable HTTP/2 Multiplexing > > Nice! Getting closer to having it working all the way but this flag is needed for us to keep digging deeper into it. This particular flag on curl_multi got lost in us dividing up patches to land. > > > Source/WebCore/ChangeLog:8 > > + Covered by existing tests. > > I do not think WebKit has HTTP/2 test infra so I guess you have your own > internal tests? Oh my mistake. I figured there was something in there to test that HTTP/2 is working properly. > > > Source/WebCore/platform/network/curl/CurlContext.cpp:202 > > + curl_multi_setopt(m_multiHandle, CURLMOPT_PIPELINING, CURLPIPE_MULTIPLEX); > > Will the handle support both HTTP/2 and HTTP/1.1? Yea internally curl makes that decision.
Comment on attachment 340654 [details] Patch Clearing flags on attachment: 340654 Committed r231932: <https://trac.webkit.org/changeset/231932>
All reviewed patches have been landed. Closing bug.
<rdar://problem/40350788>