Bug 185746 – [Curl] Enable HTTP/2 Multiplexing

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Don Olmstead]

libcurl requires setup to enable HTTP/2 multiplexing in a multi handle.

[Don Olmstead]

Created attachment 340654 [details]
Patch

[youenn fablet]

Comment on attachment 340654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340654&action=review

> Source/WebCore/ChangeLog:3
> +        [Curl] Enable HTTP/2 Multiplexing

Nice!

> Source/WebCore/ChangeLog:8
> +        Covered by existing tests.

I do not think WebKit has HTTP/2 test infra so I guess you have your own internal tests?

> Source/WebCore/platform/network/curl/CurlContext.cpp:202
> +        curl_multi_setopt(m_multiHandle, CURLMOPT_PIPELINING, CURLPIPE_MULTIPLEX);

Will the handle support both HTTP/2 and HTTP/1.1?

[Don Olmstead]

(In reply to youenn fablet from comment #2)
> Comment on attachment 340654 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340654&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [Curl] Enable HTTP/2 Multiplexing
> 
> Nice!

Getting closer to having it working all the way but this flag is needed for us to keep digging deeper into it. This particular flag on curl_multi got lost in us dividing up patches to land.

> 
> > Source/WebCore/ChangeLog:8
> > +        Covered by existing tests.
> 
> I do not think WebKit has HTTP/2 test infra so I guess you have your own
> internal tests?

Oh my mistake. I figured there was something in there to test that HTTP/2 is working properly.

> 
> > Source/WebCore/platform/network/curl/CurlContext.cpp:202
> > +        curl_multi_setopt(m_multiHandle, CURLMOPT_PIPELINING, CURLPIPE_MULTIPLEX);
> 
> Will the handle support both HTTP/2 and HTTP/1.1?

Yea internally curl makes that decision.

[WebKit Commit Bot]

Comment on attachment 340654 [details]
Patch

Clearing flags on attachment: 340654

Committed r231932: <https://trac.webkit.org/changeset/231932>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40350788>