Bug 185741 – Web Inspector: Popover dismissed while attempting to move cursor inside

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Created attachment 340626 [details]
[Test Page] Popover dismissed too soon

Summary:
Popover dismissed while attempting to move cursor inside. When a popover is shown for the hovered symbol, passing over the symbol directly beneath the popover arrow when attempting to mouse into the popover will cause it to be replaced by the second symbol's popover.

This is extremely frustrating.

Steps to Reproduce:
1. Open attached test page
2. Click the button
3. Once paused in the debugger, resize the Inspector to match the attached video
4. Hover "localA"
  => Popover shown appear, positioned below the symbol
5. Attempt to move the mouse directly down, into the popover
  => Popover is dismissed, "localB" popover shown

[Matt Baker]

Created attachment 340627 [details]
[Video] Popover frustration

[Radar WebKit Bug Importer]

<rdar://problem/40340938>

[Matt Baker]

Created attachment 341238 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 341238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341238&action=review

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1819
> +                let intersection = bounds.intersectionWithRect(this._popover.frame);

Nice! Should we expand this a little around the edges, or is it mostly just the transparent portion next to the "arrow" edge?

[EWS Watchlist]

Comment on attachment 341238 [details]
Patch

Attachment 341238 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7795427

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 341251 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Matt Baker]

Created attachment 341291 [details]
[Image] Popover frame boundary

[Matt Baker]

Comment on attachment 341238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341238&action=review

>> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1819
>> +                let intersection = bounds.intersectionWithRect(this._popover.frame);
> 
> Nice! Should we expand this a little around the edges, or is it mostly just the transparent portion next to the "arrow" edge?

I would say yes, but the popover frame already includes a couple pixels of semi-transparent box shadow around the popover's background. The "arrow" edge was the main issue, as the cursor passes over it when mousing into the popover from the hovered token.

[WebKit Commit Bot]

Comment on attachment 341238 [details]
Patch

Clearing flags on attachment: 341238

Committed r232189: <https://trac.webkit.org/changeset/232189>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.