Bug 185740 - [MSE][GStreamer] Force segment.start = 0 after matroskademux
Summary: [MSE][GStreamer] Force segment.start = 0 after matroskademux
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
Depends on:
Reported: 2018-05-17 12:40 PDT by Alicia Boya García
Modified: 2018-05-21 04:52 PDT (History)
4 users (show)

See Also:

Patch (4.65 KB, patch)
2018-05-17 12:51 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2018-05-17 12:40:34 PDT
This patch ensures that when WebM MSE media segments are appended in
an out of order fashion their frames are not discarded by opusparse or
any other potential elements downstream in the AppendPipeline that
perform segment clipping.

This patch fixes the following YTTV 2018 tests:

38. OpusAudioWithOverlap
39. OpusAudioWithSmallGap
40. OpusAudioWithLargeGap
70. VP9VideoWithOverlap
71. VP9VideoWithSmallGap

This patch is necessary, but not sufficient for fixing the following
YTTV 2018 tests:

36. AppendOpusAudioOutOfOrder
67. AppendVP9VideoOutOfOrder
Comment 1 Alicia Boya García 2018-05-17 12:51:33 PDT
Created attachment 340628 [details]
Comment 2 Xabier Rodríguez Calvar 2018-05-21 04:11:32 PDT
It looks good. Let's have Quique having last word.
Comment 3 WebKit Commit Bot 2018-05-21 04:52:39 PDT
Comment on attachment 340628 [details]

Clearing flags on attachment: 340628

Committed r232014: <https://trac.webkit.org/changeset/232014>
Comment 4 WebKit Commit Bot 2018-05-21 04:52:40 PDT
All reviewed patches have been landed.  Closing bug.