Bug 185736 - Ensure valid rects for fullsceen animation.
Summary: Ensure valid rects for fullsceen animation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-17 10:47 PDT by Jeremy Jones
Modified: 2018-05-23 09:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.48 KB, patch)
2018-05-17 10:50 PDT, Jeremy Jones 		jer.noble: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Patch for Landing (2.58 KB, patch)
2018-05-17 11:00 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-sierra (2.30 MB, application/zip)
2018-05-17 11:56 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2018-05-17 10:47:06 PDT 
Ensure valid rects for fullsceen animation.
Comment 1 Jeremy Jones 2018-05-17 10:48:25 PDT 
rdar://problem/40320174
Comment 2 Jeremy Jones 2018-05-17 10:50:36 PDT 
Created attachment 340599 [details]
Patch
Comment 3 Jer Noble 2018-05-17 10:55:33 PDT 
Comment on attachment 340599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340599&action=review

r=me with nit:

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:507
> +    
> +    _initialFrame.size.width = std::max(_initialFrame.size.width, 1.0);
> +    _initialFrame.size.height = std::max(_initialFrame.size.height, 1.0);

You could have a helper function here:

static CGSize sizeExpandedToSize(CGSize initial, CGSize other)
{
    return CGSizeMake(std::max(initial.width, other.width),  std::max(initial.height, other.height));
}
Comment 4 Jeremy Jones 2018-05-17 10:58:34 PDT 
(In reply to Jer Noble from comment #3)
> Comment on attachment 340599 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340599&action=review
> 
> r=me with nit:
> 
> > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:507
> > +    
> > +    _initialFrame.size.width = std::max(_initialFrame.size.width, 1.0);
> > +    _initialFrame.size.height = std::max(_initialFrame.size.height, 1.0);
> 
> You could have a helper function here:
> 
> static CGSize sizeExpandedToSize(CGSize initial, CGSize other)
> {
>     return CGSizeMake(std::max(initial.width, other.width), 
> std::max(initial.height, other.height));
> }

Done.
Comment 5 Jeremy Jones 2018-05-17 11:00:13 PDT 
Created attachment 340604 [details]
Patch for Landing
Comment 6 WebKit Commit Bot 2018-05-17 11:47:12 PDT 
Comment on attachment 340604 [details]
Patch for Landing

Clearing flags on attachment: 340604

Committed r231914: <https://trac.webkit.org/changeset/231914>
Comment 7 EWS Watchlist 2018-05-17 11:56:50 PDT 
Comment on attachment 340599 [details]
Patch

Attachment 340599 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7712249

New failing tests:
media/modern-media-controls/scrubber-support/scrubber-support-drag.html
Comment 8 EWS Watchlist 2018-05-17 11:56:51 PDT 
Created attachment 340618 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6