Bug 185736 – Ensure valid rects for fullsceen animation.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

Ensure valid rects for fullsceen animation.

[Jeremy Jones]

rdar://problem/40320174

[Jeremy Jones]

Created attachment 340599 [details]
Patch

[Jer Noble]

Comment on attachment 340599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340599&action=review

r=me with nit:

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:507
> +    
> +    _initialFrame.size.width = std::max(_initialFrame.size.width, 1.0);
> +    _initialFrame.size.height = std::max(_initialFrame.size.height, 1.0);

You could have a helper function here:

static CGSize sizeExpandedToSize(CGSize initial, CGSize other)
{
    return CGSizeMake(std::max(initial.width, other.width),  std::max(initial.height, other.height));
}

[Jeremy Jones]

(In reply to Jer Noble from comment #3)
> Comment on attachment 340599 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340599&action=review
> 
> r=me with nit:
> 
> > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:507
> > +    
> > +    _initialFrame.size.width = std::max(_initialFrame.size.width, 1.0);
> > +    _initialFrame.size.height = std::max(_initialFrame.size.height, 1.0);
> 
> You could have a helper function here:
> 
> static CGSize sizeExpandedToSize(CGSize initial, CGSize other)
> {
>     return CGSizeMake(std::max(initial.width, other.width), 
> std::max(initial.height, other.height));
> }

Done.

[Jeremy Jones]

Created attachment 340604 [details]
Patch for Landing

[WebKit Commit Bot]

Comment on attachment 340604 [details]
Patch for Landing

Clearing flags on attachment: 340604

Committed r231914: <https://trac.webkit.org/changeset/231914>

[EWS Watchlist]

Comment on attachment 340599 [details]
Patch

Attachment 340599 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7712249

New failing tests:
media/modern-media-controls/scrubber-support/scrubber-support-drag.html

[EWS Watchlist]

Created attachment 340618 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6