Bug 185727 - Remove cssom-remove-shorthand-property.html test
Summary: Remove cssom-remove-shorthand-property.html test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 177684
  Show dependency treegraph
 
Reported: 2018-05-17 07:38 PDT by Rob Buis
Modified: 2018-05-17 22:14 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.67 KB, patch)
2018-05-17 07:40 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2018-05-17 07:38:13 PDT
The exact same test is contained in WPT:
cssom/cssom-setProperty-shorthand.html
Comment 1 Rob Buis 2018-05-17 07:40:10 PDT
Created attachment 340582 [details]
Patch
Comment 2 WebKit Commit Bot 2018-05-17 08:27:44 PDT
Comment on attachment 340582 [details]
Patch

Clearing flags on attachment: 340582

Committed r231898: <https://trac.webkit.org/changeset/231898>
Comment 3 WebKit Commit Bot 2018-05-17 08:27:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-05-17 08:28:24 PDT
<rdar://problem/40331782>
Comment 5 Alexey Proskuryakov 2018-05-17 13:01:05 PDT
It's not great to remove tests, because that loses all the history. In this case, how would one know that there was discussion in https://bugs.webkit.org/show_bug.cgi?id=68551 ?

I guess at least there's a link from WPT source. But it's so much harder to find.
Comment 6 Frédéric Wang (:fredw) 2018-05-17 22:14:11 PDT
(In reply to Alexey Proskuryakov from comment #5)
> It's not great to remove tests, because that loses all the history. In this
> case, how would one know that there was discussion in
> https://bugs.webkit.org/show_bug.cgi?id=68551 ?
> 
> I guess at least there's a link from WPT source. But it's so much harder to
> find.

Yes, sorry about that. This came in the context of bug 177684, probably it would have make more sense for us to not apply the rule of splitting work into smaller patches here, so that we preserve the history link between the new file and old file (at least that's not worse than when people rename/move directories or files in WebKit). I'm adding a Bugzilla dependency to improve that a bit for future searches.

Anyway, I believe it makes sense to migrate to a WPT test and remove duplicate tests for this kind of bug reports, which could have been noticed earlier if the people who fixed the behavior in other browsers or clarified a spec had written new WPT tests and if one had sync CSSOM tests between WPT and WebKit.

For Web Platform development, it seems more helpful to me to link to interoperability tests, to the current specs or to other browsers' behaviors than to discussions that happened several years ago (not saying these discussions were not important of course).