Bug 185723 - [MSE][GStreamer] Fix the deadlock caused by bug 185242 (r231351)
Summary: [MSE][GStreamer] Fix the deadlock caused by bug 185242 (r231351)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 185725
  Show dependency treegraph
 
Reported: 2018-05-17 06:21 PDT by Yacine Bandou
Modified: 2018-05-22 02:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.20 KB, patch)
2018-05-17 10:55 PDT, Yacine Bandou
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yacine Bandou 2018-05-17 06:21:47 PDT
After a detailed investigation, I found that, the patch r231351 doesn't fix the crash that expected to fix, it just replaces it by a deadlock.

This Patch will remove a part of r231351 which cause a deadlock.

See https://bugs.webkit.org/show_bug.cgi?id=185242#c11 and https://bugs.webkit.org/show_bug.cgi?id=185242#c12

Thanks to Alicia for her explanations in bugs 185242 and 185592.
Comment 1 Yacine Bandou 2018-05-17 10:55:42 PDT
Created attachment 340601 [details]
Patch
Comment 2 WebKit Commit Bot 2018-05-22 02:32:52 PDT
Comment on attachment 340601 [details]
Patch

Clearing flags on attachment: 340601

Committed r232058: <https://trac.webkit.org/changeset/232058>
Comment 3 WebKit Commit Bot 2018-05-22 02:32:54 PDT
All reviewed patches have been landed.  Closing bug.