Bug 185716 - Stop softlinking QuickLook when loading from client-registered schemes
Summary: Stop softlinking QuickLook when loading from client-registered schemes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-17 01:32 PDT by Tim Horton
Modified: 2018-05-18 09:50 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.90 KB, patch)
2018-05-17 01:32 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (3.47 KB, patch)
2018-05-17 11:50 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (4.90 KB, patch)
2018-05-17 15:05 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.73 MB, application/zip)
2018-05-17 19:32 PDT, EWS Watchlist
no flags Details
Patch (5.21 KB, patch)
2018-05-17 23:39 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-05-17 01:32:06 PDT
Stop softlinking QuickLook when loading from client-registered schemes
Comment 1 Tim Horton 2018-05-17 01:32:23 PDT
Created attachment 340562 [details]
Patch
Comment 2 mitz 2018-05-17 01:35:05 PDT
Comment on attachment 340562 [details]
Patch

Please file an Apple-internal bug asking for Quick Look to publish this constant in a header, or have it exposed from a library that both WebCore and Quick Look already use.
Comment 3 mitz 2018-05-17 10:39:54 PDT
<rdar://problem/40303227>
Comment 4 Tim Horton 2018-05-17 11:50:20 PDT
Created attachment 340615 [details]
Patch
Comment 5 Tim Horton 2018-05-17 15:05:56 PDT
Created attachment 340656 [details]
Patch
Comment 6 EWS Watchlist 2018-05-17 19:32:46 PDT
Comment on attachment 340656 [details]
Patch

Attachment 340656 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7717818

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 7 EWS Watchlist 2018-05-17 19:32:57 PDT
Created attachment 340673 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 8 Tim Horton 2018-05-17 23:39:51 PDT
Created attachment 340682 [details]
Patch
Comment 9 WebKit Commit Bot 2018-05-18 01:11:23 PDT
Comment on attachment 340682 [details]
Patch

Clearing flags on attachment: 340682

Committed r231949: <https://trac.webkit.org/changeset/231949>
Comment 10 WebKit Commit Bot 2018-05-18 01:11:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Darin Adler 2018-05-18 09:50:34 PDT
Comment on attachment 340682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340682&action=review

> Source/WebCore/platform/ios/QuickLook.h:46
> +extern const char* QLPreviewProtocol;

I suggest we consider a tiny bit more const here, because without the const, this is a global that can be changed to point to another string.

    extern const char* const QLPreviewProtocol;

> Source/WebCore/platform/ios/QuickLook.mm:43
> +const char* QLPreviewProtocol = "x-apple-ql-id";

Would need to add the extra const here too.