Stop softlinking QuickLook when loading from client-registered schemes
Created attachment 340562 [details] Patch
Comment on attachment 340562 [details] Patch Please file an Apple-internal bug asking for Quick Look to publish this constant in a header, or have it exposed from a library that both WebCore and Quick Look already use.
<rdar://problem/40303227>
Created attachment 340615 [details] Patch
Created attachment 340656 [details] Patch
Comment on attachment 340656 [details] Patch Attachment 340656 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7717818 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html
Created attachment 340673 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 340682 [details] Patch
Comment on attachment 340682 [details] Patch Clearing flags on attachment: 340682 Committed r231949: <https://trac.webkit.org/changeset/231949>
All reviewed patches have been landed. Closing bug.
Comment on attachment 340682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340682&action=review > Source/WebCore/platform/ios/QuickLook.h:46 > +extern const char* QLPreviewProtocol; I suggest we consider a tiny bit more const here, because without the const, this is a global that can be changed to point to another string. extern const char* const QLPreviewProtocol; > Source/WebCore/platform/ios/QuickLook.mm:43 > +const char* QLPreviewProtocol = "x-apple-ql-id"; Would need to add the extra const here too.