WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
185705
DFG backend for CheckTypeInfoFlags won't work if we ever pass in a bitset with more than one bit set and we want to test that all bits are set
https://bugs.webkit.org/show_bug.cgi?id=185705
Summary
DFG backend for CheckTypeInfoFlags won't work if we ever pass in a bitset wit...
Saam Barati
Reported
2018-05-16 17:03:02 PDT
speculationCheck(BadTypeInfoFlags, JSValueRegs(), 0, m_jit.branchTest8(MacroAssembler::Zero, MacroAssembler::Address(baseGPR, JSCell::typeInfoFlagsOffset()), MacroAssembler::TrustedImm32(node->typeInfoOperand())));
Attachments
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2018-05-16 17:10:14 PDT
It's not super important now since we just use this node for ImplementsDefaultHasIntance. But if we add new uses of the node, this implementation may become wrong.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug