Bug 185698 – Layout Test svg/dom/animated-tearoff-list-remove-target.html is a flaky timeout

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

Layout Test svg/dom/animated-tearoff-list-remove-target.html is a flaky timeout on macOS Debug WK1 and iOS Simulator Debug WK2

Probable cause:

Unknown.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=svg%2Fdom%2Fanimated-tearoff-list-remove-target.html

[Ryan Haddad]

This test was added in https://trac.webkit.org/changeset/230172/webkit

[Radar WebKit Bug Importer]

<rdar://problem/40341200>

[Said Abou-Hallawa]

Created attachment 342301 [details]
Patch

[EWS Watchlist]

Comment on attachment 342301 [details]
Patch

Attachment 342301 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8087634

New failing tests:
accessibility/smart-invert-reference.html

[EWS Watchlist]

Created attachment 342331 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Ryosuke Niwa]

Comment on attachment 342301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342301&action=review

> LayoutTests/svg/dom/animated-tearoff-list-remove-target.html:54
> +            }, 50);

Are we waiting for the animation to occur? If so, can we make this more deterministic by using requestAnimationFrame instead?

[Said Abou-Hallawa]

Created attachment 342349 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 342301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342301&action=review

>> LayoutTests/svg/dom/animated-tearoff-list-remove-target.html:54
>> +            }, 50);
> 
> Are we waiting for the animation to occur? If so, can we make this more deterministic by using requestAnimationFrame instead?

Yes. Done.

[Daniel Bates]

Comment on attachment 342349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342349&action=review

> LayoutTests/ChangeLog:22
> +        Reviewed by NOBODY (OOPS!).

This line should be before the description (line 7).

[Said Abou-Hallawa]

Created attachment 342460 [details]
Patch

[Said Abou-Hallawa]

Created attachment 342468 [details]
Patch

[Said Abou-Hallawa]

Created attachment 342482 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 342482 [details]
Patch

Clearing flags on attachment: 342482

Committed r232736: <https://trac.webkit.org/changeset/232736>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

The test is no longer a flaky timeout, but now it is a flaky failure on iOS and macOS :(

--- /Volumes/Data/slave/highsierra-leaks/build/layout-test-results/svg/dom/animated-tearoff-list-remove-target-expected.txt
+++ /Volumes/Data/slave/highsierra-leaks/build/layout-test-results/svg/dom/animated-tearoff-list-remove-target-actual.txt
@@ -1,4 +1,4 @@
 Removing the target of an animate element should detach the wrappers of the attributes from their animated properties.
+First tspan.
+Second tspan
 
-PASS.
-

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r232770%20(10781)/results.html

[Said Abou-Hallawa]

I think the issue is fixed by the followup patch: <https://trac.webkit.org/changeset/232780>.