Bug 185691 – Host jquery on webkit.org instead of 3rd party

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Roy Reapor]

Host jquery on webkit.org instead of 3rd party.

[Radar WebKit Bug Importer]

<rdar://problem/40304594>

[Roy Reapor]

Created attachment 340542 [details]
Patch

[Aakash Jain]

Looks good to me. Alexey might want to have a quick look.

[Darin Adler]

Comment on attachment 340542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340542&action=review

> Websites/webkit.org/demos/spring/index.html:-5
> -<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro" rel="stylesheet">

Why remove this, but still specify "Source Sans Pro" in the stylesheet below?

[Roy Reapor]

Created attachment 340592 [details]
Patch

[Roy Reapor]

(In reply to Darin Adler from comment #4)
> Comment on attachment 340542 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340542&action=review
> 
> > Websites/webkit.org/demos/spring/index.html:-5
> > -<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro" rel="stylesheet">
> 
> Why remove this, but still specify "Source Sans Pro" in the stylesheet below?

Patch submitted. Source Sans Pro should be committed from the the stylesheets.

[Roy Reapor]

(In reply to Roy Reapor from comment #6)
> (In reply to Darin Adler from comment #4)
> > Comment on attachment 340542 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=340542&action=review
> > 
> > > Websites/webkit.org/demos/spring/index.html:-5
> > > -<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro" rel="stylesheet">
> > 
> > Why remove this, but still specify "Source Sans Pro" in the stylesheet below?
> 
> Patch submitted. Source Sans Pro should be committed from the the
> stylesheets.

Typo 

Patch submitted. Source Sans Pro should be *omitted* from the the stylesheets.

[Alexey Proskuryakov]

Comment on attachment 340592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340592&action=review

> Websites/bugs.webkit.org/ChangeLog:3
> +        Host jquery on webkit.org instead of 3rd party

Looks good.

This takes care of one of those, do you intend to have separate patches for the others? I see uses in Tools//BuildSlaveSupport/build.webkit.org-config, Tools/TestResultServer, and there is a grep match that I'm unsure about in Tools/Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch.

> Websites/webkit.org/demos/spring/index.html:-5
> -<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro" rel="stylesheet">

It's probably better to do this in a separate patch anyway, as the bug title is about jquery only.

[Roy Reapor]

(In reply to Alexey Proskuryakov from comment #8)
> Comment on attachment 340592 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340592&action=review
> 
> > Websites/bugs.webkit.org/ChangeLog:3
> > +        Host jquery on webkit.org instead of 3rd party
> 
> Looks good.
> 
> This takes care of one of those, do you intend to have separate patches for
> the others? I see uses in Tools//BuildSlaveSupport/build.webkit.org-config,
> Tools/TestResultServer, and there is a grep match that I'm unsure about in
> Tools/Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch.
> 
> > Websites/webkit.org/demos/spring/index.html:-5
> > -<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro" rel="stylesheet">
> 
> It's probably better to do this in a separate patch anyway, as the bug title
> is about jquery only.

Ok. I am going to create a separate bug for files under Tools. If needed, I'll create one for "Source Sans Pro" as well.

[Roy Reapor]

Created attachment 340613 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 340613 [details]
Patch

Clearing flags on attachment: 340613

Committed r232068: <https://trac.webkit.org/changeset/232068>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.