Bug 185685 – [Wi-Fi Assertions] Adopt WiFiAssertionHolderAdditions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Wi-Fi Assertions] Adopt WiFiAssertionHolderAdditions

[Andy Estes]

Created attachment 340497 [details]
Patch

[Andy Estes]

rdar://problem/40136681

[Sam Weinig]

Comment on attachment 340497 [details]
Patch

I might use less generic names than holdAssertion()/releaseAssertion(), but otherwise, looks good.

[Timothy Hatcher]

Comment on attachment 340497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340497&action=review

> Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp:39
> +    holdAssertion();

You will either need to add #if USE(APPLE_INTERNAL_SDK) around the call here or define empty stub functions above.

> Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp:44
> +    releaseAssertion();

Ditto.

[Andy Estes]

(In reply to Timothy Hatcher from comment #4)
> Comment on attachment 340497 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340497&action=review
> 
> > Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp:39
> > +    holdAssertion();
> 
> You will either need to add #if USE(APPLE_INTERNAL_SDK) around the call here
> or define empty stub functions above.
> 
> > Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp:44
> > +    releaseAssertion();
> 
> Ditto.

Technically I don't need to due to how HAVE_MOBILE_WIFI is defined, but I agree this is  the right way to do it, so I'll do it!

[Andy Estes]

Created attachment 340513 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 340513 [details]
Patch

Clearing flags on attachment: 340513

Committed r231863: <https://trac.webkit.org/changeset/231863>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.