Bug 185658 - [modern-media-controls] AirPlaySupport should be disabled by default
Summary: [modern-media-controls] AirPlaySupport should be disabled by default
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
Keywords: InRadar
: 185751 (view as bug list)
Depends on:
Reported: 2018-05-15 14:45 PDT by Jer Noble
Modified: 2018-05-18 07:08 PDT (History)
5 users (show)

See Also:

Patch (8.21 KB, patch)
2018-05-17 06:28 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-05-15 14:45:39 PDT
AirPlaySupport inherits from MediaControllerSupport, which enables the support object at construction time. This means that the controls will always add a airplay route availability listener, even if they are invisible. They will be disabled eventually, but that's too late, as the listener has already kicked off the airplay route listening machinery.
Comment 1 Radar WebKit Bug Importer 2018-05-15 14:46:08 PDT
Comment 2 Jer Noble 2018-05-15 14:46:27 PDT
Additionally, the AirPlaySupport object should remain disabled when displaying only the "big play button" on iOS, since there's no visible airplay route change button.
Comment 3 Antoine Quint 2018-05-17 06:28:05 PDT
Created attachment 340577 [details]
Comment 4 WebKit Commit Bot 2018-05-17 08:34:43 PDT
Comment on attachment 340577 [details]

Clearing flags on attachment: 340577

Committed r231899: <https://trac.webkit.org/changeset/231899>
Comment 5 WebKit Commit Bot 2018-05-17 08:34:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2018-05-17 14:14:23 PDT
This change appears to have caused the following two LayoutTests to become flaky timeouts on macOS:

Comment 7 Ryan Haddad 2018-05-17 15:15:11 PDT
Reverted r231899 for reason:

Caused flakiness in two existing modern-media-controls tests.

Committed r231923: <https://trac.webkit.org/changeset/231923>
Comment 8 Ryan Haddad 2018-05-17 17:22:03 PDT
*** Bug 185751 has been marked as a duplicate of this bug. ***
Comment 9 Antoine Quint 2018-05-18 07:08:53 PDT
Committed r231950: <https://trac.webkit.org/changeset/231950>