Bug 185648 - Update animation when presenting QuickLook
Summary: Update animation when presenting QuickLook
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-15 03:21 PDT by Dean Jackson
Modified: 2018-05-15 03:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2018-05-15 03:25 PDT, Dean Jackson 		graouts: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-05-15 03:21:19 PDT 
Update animation when presenting QuickLook
Comment 1 Dean Jackson 2018-05-15 03:21:54 PDT 
<rdar://problem/39652624>
Comment 2 Dean Jackson 2018-05-15 03:25:19 PDT 
Created attachment 340402 [details]
Patch
Comment 3 Antoine Quint 2018-05-15 03:29:24 PDT 
Comment on attachment 340402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340402&action=review

> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:142
> +    frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5, 10, 10);

You should make 10 a named constant and replace 5 with half that value.
Comment 4 Dean Jackson 2018-05-15 03:30:07 PDT 
Comment on attachment 340402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340402&action=review

>> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:142
>> +    frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5, 10, 10);
> 
> You should make 10 a named constant and replace 5 with half that value.

I think I'll make the rect 50% of the width and height instead.
Comment 5 Dean Jackson 2018-05-15 03:37:38 PDT 
Committed r231797: <https://trac.webkit.org/changeset/231797>