Bug 185628 - Test262-Runner: Update config list with some failing tests
Summary: Test262-Runner: Update config list with some failing tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Balter
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-14 14:34 PDT by Leo Balter
Modified: 2018-06-15 13:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.61 KB, patch)
2018-05-14 14:36 PDT, Leo Balter
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews201 for win-future (12.78 MB, application/zip)
2018-05-14 17:45 PDT, EWS Watchlist
no flags Details
Patch (2.61 KB, patch)
2018-06-14 11:49 PDT, Leo Balter
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Balter 2018-05-14 14:34:20 PDT
Test262-Runner: Update config list with some failing tests
Comment 1 Leo Balter 2018-05-14 14:36:07 PDT
Created attachment 340360 [details]
Patch
Comment 2 Leo Balter 2018-05-14 14:36:52 PDT
The config list is updated to match some slow / hanging tests that are currently failing due to the length used in Array or Array like objects.

This also adds matching bugs for known features that are still in progress and not enabled yet.
Comment 3 EWS Watchlist 2018-05-14 17:44:55 PDT
Comment on attachment 340360 [details]
Patch

Attachment 340360 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7683760

New failing tests:
http/tests/security/contentSecurityPolicy/video-redirect-allowed2.html
Comment 4 EWS Watchlist 2018-05-14 17:45:06 PDT
Created attachment 340382 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Michael Saboff 2018-06-12 12:29:41 PDT
Comment on attachment 340360 [details]
Patch

Is this still an accurate list of slow / hanging test?

r=me after updating the list and rebasing the patch.
Comment 6 Leo Balter 2018-06-14 11:49:37 PDT
Created attachment 342750 [details]
Patch
Comment 7 Leo Balter 2018-06-14 11:52:02 PDT
this list is still accurate, including for known failures with their proper tracking bugs.

My idea is to follow up, migrating tests from the expectations file to this list after we have a matching bug. When the bug is fixed, it should serve as an index to gradually remove the files from the list.
Comment 8 Michael Saboff 2018-06-14 14:13:27 PDT
Comment on attachment 342750 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2018-06-14 14:40:36 PDT
Comment on attachment 342750 [details]
Patch

Clearing flags on attachment: 342750

Committed r232853: <https://trac.webkit.org/changeset/232853>
Comment 10 WebKit Commit Bot 2018-06-14 14:40:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-06-14 14:42:10 PDT
<rdar://problem/41139641>
Comment 12 Dawei Fenton (:realdawei) 2018-06-15 13:36:10 PDT
(In reply to WebKit Commit Bot from comment #9)
> Comment on attachment 342750 [details]
> Patch
> 
> Clearing flags on attachment: 342750
> 
> Committed r232853: <https://trac.webkit.org/changeset/232853>


Seem we have quite a few Test262 failures after this patch

Leo, can you take a look?
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20Test262%20%28Tests%29/builds/2895/steps/test262-test/logs/stdio
Comment 13 Leo Balter 2018-06-15 13:47:53 PDT
Thanks for the report, David. 

I just noticed the Yaml module used for the test262-runner is bundling considering inline comments from the config list. So the skip list for the e.g. BigInt tests will capture the inline comment as well.

While I'm yet to fix that in the runner, I will send a quick patch to avoid the inline comments so the bot will be back to normal anytime soon
Comment 14 Dawei Fenton (:realdawei) 2018-06-15 13:48:53 PDT
(In reply to Leo Balter from comment #13)
> Thanks for the report, David. 
> 
> I just noticed the Yaml module used for the test262-runner is bundling
> considering inline comments from the config list. So the skip list for the
> e.g. BigInt tests will capture the inline comment as well.
> 
> While I'm yet to fix that in the runner, I will send a quick patch to avoid
> the inline comments so the bot will be back to normal anytime soon

great thanks!