Bug 185619 - Exit fullscreen when javascript alerts are presented.
Summary: Exit fullscreen when javascript alerts are presented.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
: 185618 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-05-14 12:10 PDT by Jeremy Jones
Modified: 2018-06-02 09:02 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.81 KB, patch)
2018-05-14 12:30 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.77 MB, application/zip)
2018-05-14 15:24 PDT, EWS Watchlist
no flags Details
Patch (8.75 KB, patch)
2018-05-25 05:49 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (22.59 MB, application/zip)
2018-05-25 07:38 PDT, EWS Watchlist
no flags Details
Patch (3.85 KB, patch)
2018-06-01 09:39 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2018-05-14 12:10:24 PDT
Exit fullscreen when javascript alerts are presented.
Comment 1 Jeremy Jones 2018-05-14 12:16:49 PDT
rdar://problem/35724264
Comment 2 Jeremy Jones 2018-05-14 12:30:03 PDT
Created attachment 340341 [details]
Patch
Comment 3 EWS Watchlist 2018-05-14 15:24:31 PDT
Comment on attachment 340341 [details]
Patch

Attachment 340341 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7682039

New failing tests:
http/tests/preload/onload_event.html
Comment 4 EWS Watchlist 2018-05-14 15:24:41 PDT
Created attachment 340367 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Alexey Proskuryakov 2018-05-16 20:26:00 PDT
*** Bug 185618 has been marked as a duplicate of this bug. ***
Comment 6 Jeremy Jones 2018-05-25 05:49:48 PDT
Created attachment 341274 [details]
Patch
Comment 7 EWS Watchlist 2018-05-25 07:38:19 PDT
Comment on attachment 341274 [details]
Patch

Attachment 341274 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7799244

New failing tests:
fullscreen/full-screen-exit-when-alert.html
Comment 8 EWS Watchlist 2018-05-25 07:38:21 PDT
Created attachment 341280 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 9 Jeremy Jones 2018-06-01 09:39:11 PDT
Created attachment 341765 [details]
Patch
Comment 10 Jer Noble 2018-06-01 10:52:40 PDT
Comment on attachment 341765 [details]
Patch

WK1? We should be able to write an API test for this.
Comment 11 Jeremy Jones 2018-06-01 15:21:48 PDT
(In reply to Jer Noble from comment #10)
> Comment on attachment 341765 [details]
> Patch
> 
> WK1? We should be able to write an API test for this.

This feature is WK2 iOS only.
Comment 12 WebKit Commit Bot 2018-06-02 09:02:20 PDT
Comment on attachment 341765 [details]
Patch

Clearing flags on attachment: 341765

Committed r232437: <https://trac.webkit.org/changeset/232437>
Comment 13 WebKit Commit Bot 2018-06-02 09:02:22 PDT
All reviewed patches have been landed.  Closing bug.