RESOLVED WONTFIX 185616
Add runtime check for multi-thread support of SQLite database. 
https://bugs.webkit.org/show_bug.cgi?id=185616
Summary Add runtime check for multi-thread support of SQLite database.
Basuke Suzuki
Reported 2018-05-14 10:41:47 PDT
SQLite supports multi-thread for long time. https://www.sqlite.org/threadsafe.html Our code base is allowing to be used from multi-thread by calling disableThreadingChecks() method. As name implies, it's just disabling assert check on debugging mode. Also the name is very much like workaround-ish. Let's make the name more positive name such as allowMultiThreadUsage or something, and we can add runtime check of threading support of the libsqlite.
Attachments
PAtCH (8.76 KB, patch)
2018-05-14 12:18 PDT, Basuke Suzuki 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-sierra (3.07 MB, application/zip)
2018-05-14 14:14 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-05-14 12:18:12 PDT
Created attachment 340338 [details] PAtCH
EWS Watchlist
Comment 2 2018-05-14 14:14:39 PDT
Comment on attachment 340338 [details] PAtCH Attachment 340338 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7680863 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 3 2018-05-14 14:14:40 PDT
Created attachment 340357 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Basuke Suzuki
Comment 4 2020-01-15 12:50:16 PST
Gave up
Alex Christensen
Comment 5 2021-11-01 12:14:46 PDT
Comment on attachment 340338 [details] PAtCH This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Basuke Suzuki
Comment 6 2021-11-01 12:25:57 PDT
Got it. THanks.
Note You need to log in before you can comment on or make changes to this bug.