Bug 185602 - readableStreamDefaultControllerError should return early if stream is not readable
Summary: readableStreamDefaultControllerError should return early if stream is not rea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-14 00:22 PDT by youenn fablet
Modified: 2018-05-14 22:37 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.24 KB, patch)
2018-05-14 00:24 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (17.15 KB, patch)
2018-05-14 01:14 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.80 MB, application/zip)
2018-05-14 05:25 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-05-14 00:22:19 PDT
As per https://streams.spec.whatwg.org/#readable-stream-default-controller-error, we currently assert which fails in some tee cases
Comment 1 youenn fablet 2018-05-14 00:24:52 PDT
Created attachment 340296 [details]
Patch
Comment 2 youenn fablet 2018-05-14 01:14:11 PDT
Created attachment 340301 [details]
Patch
Comment 3 EWS Watchlist 2018-05-14 05:25:33 PDT
Comment on attachment 340301 [details]
Patch

Attachment 340301 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7676135

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 4 EWS Watchlist 2018-05-14 05:25:44 PDT
Created attachment 340307 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 WebKit Commit Bot 2018-05-14 22:35:30 PDT
Comment on attachment 340301 [details]
Patch

Clearing flags on attachment: 340301

Committed r231789: <https://trac.webkit.org/changeset/231789>
Comment 6 WebKit Commit Bot 2018-05-14 22:35:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-14 22:37:10 PDT
<rdar://problem/40246179>