Bug 185600 - Make all SVG shape interfaces inherit from SVGGeometryElement
Summary: Make all SVG shape interfaces inherit from SVGGeometryElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords: InRadar
Depends on:
Blocks: 184767
  Show dependency tree / graph
 
Reported: 2018-05-13 20:55 PDT by Dirk Schulze
Modified: 2018-05-18 08:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (50.75 KB, patch)
2018-05-13 21:17 PDT, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Patch for landing (52.92 KB, patch)
2018-05-18 07:38 PDT, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2018-05-13 20:55:48 PDT 
Make all SVG shape interfaces inherit from SVGGeometryElement as defined by SVG2.

https://svgwg.org/svg2-draft/shapes.html#DOMInterfaces
Comment 1 Dirk Schulze 2018-05-13 21:17:41 PDT 
Created attachment 340288 [details]
Patch
Comment 2 Antti Koivisto 2018-05-16 23:35:38 PDT 
Comment on attachment 340288 [details]
Patch

r=me
Comment 3 Antti Koivisto 2018-05-16 23:37:40 PDT 
Comment on attachment 340288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340288&action=review

> Source/WebCore/rendering/svg/RenderSVGShape.cpp:362
> +    bool isValid;
> +    point = m_path->pointAtLength(distance, isValid);

What happens when the point is not valid? Is this covered by the tests?
Comment 4 Dirk Schulze 2018-05-18 07:38:07 PDT 
Created attachment 340694 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-05-18 08:23:01 PDT 
Comment on attachment 340694 [details]
Patch for landing

Clearing flags on attachment: 340694

Committed r231955: <https://trac.webkit.org/changeset/231955>
Comment 6 WebKit Commit Bot 2018-05-18 08:23:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-18 08:24:17 PDT 
<rdar://problem/40365807>