Bug 185585 - [LFC] Implement height computation for non-replaced out of flow elements.
Summary: [LFC] Implement height computation for non-replaced out of flow elements.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-12 22:12 PDT by zalan
Modified: 2018-05-14 09:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.52 KB, patch)
2018-05-12 22:25 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.50 KB, patch)
2018-05-13 14:22 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.50 KB, patch)
2018-05-13 18:51 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.07 KB, patch)
2018-05-14 08:32 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-05-12 22:12:49 PDT 
ssia
Comment 1 zalan 2018-05-12 22:25:03 PDT 
Created attachment 340255 [details]
Patch
Comment 2 zalan 2018-05-13 14:22:56 PDT 
Created attachment 340278 [details]
Patch
Comment 3 zalan 2018-05-13 18:51:03 PDT 
Created attachment 340282 [details]
Patch
Comment 4 Antti Koivisto 2018-05-14 00:10:09 PDT 
Comment on attachment 340282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340282&action=review

> Source/WebCore/layout/FormattingContext.cpp:180
> +        computedHeightValue= contentHeightForFormattingContextRoot(layoutContext, layoutBox);

Missing space before =

> Source/WebCore/layout/FormattingContext.cpp:207
> +    if (!is<Container>(layoutBox) || !downcast<Container>(layoutBox).hasInFlowOrFloatingChild()) {
> +        return 0;
>      }

Unneeded { }
Comment 5 zalan 2018-05-14 08:32:31 PDT 
Created attachment 340318 [details]
Patch
Comment 6 WebKit Commit Bot 2018-05-14 09:00:02 PDT 
Comment on attachment 340318 [details]
Patch

Clearing flags on attachment: 340318

Committed r231758: <https://trac.webkit.org/changeset/231758>
Comment 7 WebKit Commit Bot 2018-05-14 09:00:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-05-14 09:01:43 PDT 
<rdar://problem/40218919>