Implement isPointInFill and isPointInStroke for SVGGeometryElement interface from SVG2. https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement
Created attachment 340249 [details] Patch
Comment on attachment 340249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340249&action=review > Source/WebCore/rendering/svg/RenderSVGRect.h:53 > + bool shapeDependentStrokeContains(const FloatPoint&, bool isInLocalCoordinateSystem = false) override; How about enum class CoordinateSystem { Global, Local } or similar? Booleans can be confusing in call sites.
Comment on attachment 340249 [details] Patch Attachment 340249 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7661950 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Created attachment 340253 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 340256 [details] Patch for landing
Attachment 340256 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/svg/RenderSVGShape.h:81: The parameter name "pointCoordinateSpace" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/svg/RenderSVGRect.h:53: The parameter name "pointCoordinateSpace" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/svg/RenderSVGPath.h:46: The parameter name "pointCoordinateSpace" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/svg/RenderSVGEllipse.h:47: The parameter name "pointCoordinateSpace" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 340256 [details] Patch for landing Attachment 340256 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7666215 New failing tests: svg/dom/SVGGeometry-isPointInStroke.xhtml
Created attachment 340257 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 340256 [details] Patch for landing Attachment 340256 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7666231 New failing tests: svg/dom/SVGGeometry-isPointInStroke.xhtml
Created attachment 340258 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 340259 [details] Patch for landing
Comment on attachment 340259 [details] Patch for landing Rejecting attachment 340259 [details] from commit-queue. New failing tests: svg/dom/SVGGeometry-isPointInStroke.xhtml Full output: http://webkit-queues.webkit.org/results/7666653
Created attachment 340260 [details] Archive of layout-test-results from webkit-cq-03 for mac-sierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 340261 [details] Patch for landing
2 hick-ups after changing boolean to enum. Should be fixed now.
Comment on attachment 340261 [details] Patch for landing Clearing flags on attachment: 340261 Committed r231739: <https://trac.webkit.org/changeset/231739>
All reviewed patches have been landed. Closing bug.
<rdar://problem/40199770>