Bug 185580 - Implement SVGGeometryElement's isPointInFill and isPointInStroke
Summary: Implement SVGGeometryElement's isPointInFill and isPointInStroke
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords: InRadar
Depends on:
Blocks: 184767
  Show dependency treegraph
 
Reported: 2018-05-12 04:17 PDT by Dirk Schulze
Modified: 2018-05-13 02:27 PDT (History)
6 users (show)

See Also:


Attachments
Patch (31.90 KB, patch)
2018-05-12 04:32 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.80 MB, application/zip)
2018-05-12 10:23 PDT, Build Bot
no flags Details
Patch for landing (32.40 KB, patch)
2018-05-12 22:48 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.23 MB, application/zip)
2018-05-12 23:53 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.76 MB, application/zip)
2018-05-12 23:59 PDT, Build Bot
no flags Details
Patch for landing (32.32 KB, patch)
2018-05-13 00:16 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-03 for mac-sierra (2.24 MB, application/zip)
2018-05-13 01:22 PDT, WebKit Commit Bot
no flags Details
Patch for landing (32.32 KB, patch)
2018-05-13 01:47 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2018-05-12 04:17:57 PDT
Implement isPointInFill and isPointInStroke for SVGGeometryElement interface from SVG2.

https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement
Comment 1 Dirk Schulze 2018-05-12 04:32:51 PDT
Created attachment 340249 [details]
Patch
Comment 2 Antti Koivisto 2018-05-12 06:53:27 PDT
Comment on attachment 340249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340249&action=review

> Source/WebCore/rendering/svg/RenderSVGRect.h:53
> +    bool shapeDependentStrokeContains(const FloatPoint&, bool isInLocalCoordinateSystem = false) override;

How about

enum class CoordinateSystem { Global, Local } 

or similar? Booleans can be confusing in call sites.
Comment 3 Build Bot 2018-05-12 10:23:22 PDT
Comment on attachment 340249 [details]
Patch

Attachment 340249 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7661950

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 4 Build Bot 2018-05-12 10:23:32 PDT
Created attachment 340253 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Dirk Schulze 2018-05-12 22:48:26 PDT
Created attachment 340256 [details]
Patch for landing
Comment 6 Build Bot 2018-05-12 22:51:03 PDT
Attachment 340256 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/svg/RenderSVGShape.h:81:  The parameter name "pointCoordinateSpace" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGRect.h:53:  The parameter name "pointCoordinateSpace" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGPath.h:46:  The parameter name "pointCoordinateSpace" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGEllipse.h:47:  The parameter name "pointCoordinateSpace" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Build Bot 2018-05-12 23:53:16 PDT
Comment on attachment 340256 [details]
Patch for landing

Attachment 340256 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7666215

New failing tests:
svg/dom/SVGGeometry-isPointInStroke.xhtml
Comment 8 Build Bot 2018-05-12 23:53:17 PDT
Created attachment 340257 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 Build Bot 2018-05-12 23:59:53 PDT
Comment on attachment 340256 [details]
Patch for landing

Attachment 340256 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7666231

New failing tests:
svg/dom/SVGGeometry-isPointInStroke.xhtml
Comment 10 Build Bot 2018-05-12 23:59:55 PDT
Created attachment 340258 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 11 Dirk Schulze 2018-05-13 00:16:57 PDT
Created attachment 340259 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2018-05-13 01:22:23 PDT
Comment on attachment 340259 [details]
Patch for landing

Rejecting attachment 340259 [details] from commit-queue.

New failing tests:
svg/dom/SVGGeometry-isPointInStroke.xhtml
Full output: http://webkit-queues.webkit.org/results/7666653
Comment 13 WebKit Commit Bot 2018-05-13 01:22:25 PDT
Created attachment 340260 [details]
Archive of layout-test-results from webkit-cq-03 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 14 Dirk Schulze 2018-05-13 01:47:48 PDT
Created attachment 340261 [details]
Patch for landing
Comment 15 Dirk Schulze 2018-05-13 01:48:28 PDT
2 hick-ups after changing boolean to enum. Should be fixed now.
Comment 16 WebKit Commit Bot 2018-05-13 02:25:50 PDT
Comment on attachment 340261 [details]
Patch for landing

Clearing flags on attachment: 340261

Committed r231739: <https://trac.webkit.org/changeset/231739>
Comment 17 WebKit Commit Bot 2018-05-13 02:25:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 18 Radar WebKit Bug Importer 2018-05-13 02:27:14 PDT
<rdar://problem/40199770>