Bug 185561 - WebHTMLView is not setting aside subviews when drawing
Summary: WebHTMLView is not setting aside subviews when drawing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-11 13:21 PDT by Timothy Hatcher
Modified: 2018-05-11 14:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.01 KB, patch)
2018-05-11 13:32 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-05-11 13:21:50 PDT 
The method we override in AppKit has changed its signature.

- (void)_recursive:(BOOL)recurse displayRectIgnoringOpacity:(NSRect)displayRect inContext:(NSGraphicsContext *)context shouldChangeFontReferenceColor:(BOOL)shouldChangeFontReferenceColor;

is now:

- (void)_recursive:(BOOL)recursive displayRectIgnoringOpacity:(NSRect)displayRect inContext:(NSGraphicsContext *)graphicsContext shouldChangeFontReferenceColor:(BOOL)shouldChangeFontReferenceColor stopAtLayerBackedViews:(BOOL)stopAtLayerBackedViews;

Also the follow is removed:

- (void)_recursive:(BOOL)recurseX displayRectIgnoringOpacity:(NSRect)displayRect inGraphicsContext:(NSGraphicsContext *)graphicsContext shouldChangeFontReferenceColor:(BOOL)shouldChangeFontReferenceColor;
Comment 1 Radar WebKit Bug Importer 2018-05-11 13:22:53 PDT 
<rdar://problem/40172894>
Comment 2 Radar WebKit Bug Importer 2018-05-11 13:23:03 PDT 
<rdar://problem/40172901>
Comment 3 Timothy Hatcher 2018-05-11 13:32:00 PDT 
Created attachment 340217 [details]
Patch
Comment 4 WebKit Commit Bot 2018-05-11 13:59:59 PDT 
Comment on attachment 340217 [details]
Patch

Clearing flags on attachment: 340217

Committed r231718: <https://trac.webkit.org/changeset/231718>
Comment 5 WebKit Commit Bot 2018-05-11 14:00:01 PDT 
All reviewed patches have been landed.  Closing bug.