WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
185560
Add CF_NOESCAPE decorators for tvOS and watchOS
https://bugs.webkit.org/show_bug.cgi?id=185560
Summary
Add CF_NOESCAPE decorators for tvOS and watchOS
Jer Noble
Reported
2018-05-11 13:11:33 PDT
Add CF_NOESCAPE decorators for tvOS and watchOS
Attachments
Patch
(1.53 KB, patch)
2018-05-11 13:12 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(1.53 KB, patch)
2018-05-11 13:59 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2018-05-11 13:12:36 PDT
Created
attachment 340214
[details]
Patch
Jer Noble
Comment 2
2018-05-11 13:13:49 PDT
<
rdar://problem/39806412
>
mitz
Comment 3
2018-05-11 13:23:15 PDT
Comment on
attachment 340214
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=340214&action=review
> Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:40 > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED <= 120000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED <= 101400) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED <= 50000) || (PLATFORM(TVOS) && __TV_OS_VERSION_MAX_ALLOWED <= 120000)
We normally use >= or < to compare against versions. We don’t expect something to be needed for 101400 but not for 101401. Perhaps you meant < 101500 ? Similarly for the other platforms.
Jer Noble
Comment 4
2018-05-11 13:59:33 PDT
Created
attachment 340221
[details]
Patch
WebKit Commit Bot
Comment 5
2018-05-11 15:03:12 PDT
Comment on
attachment 340221
[details]
Patch Clearing flags on attachment: 340221 Committed
r231721
: <
https://trac.webkit.org/changeset/231721
>
WebKit Commit Bot
Comment 6
2018-05-11 15:03:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug