Bug 185556 - [GTK] Silence GCC 8 warnings
Summary: [GTK] Silence GCC 8 warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-11 11:42 PDT by Michael Catanzaro
Modified: 2018-05-23 10:50 PDT (History)
15 users (show)

See Also:

Attachments
Patch (9.02 KB, patch)
2018-05-11 11:48 PDT, Michael Catanzaro 		zan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-05-11 11:42:27 PDT 
Silence GCC 8 warnings. Having already done this for WPE, there's not much more left to do.

Notably, Adrian, you were wrong about the C style casts. The double cast is needed there too.
Comment 1 Michael Catanzaro 2018-05-11 11:48:03 PDT 
Created attachment 340209 [details]
Patch
Comment 2 Adrian Perez 2018-05-11 14:47:30 PDT 
(In reply to Michael Catanzaro from comment #0)
> Silence GCC 8 warnings. Having already done this for WPE, there's not much
> more left to do.
> 
> Notably, Adrian, you were wrong about the C style casts. The double cast is
> needed there too.

Well, one has to be proven wrong now and than, and that's fine.
Double-cast it is, then! FWIW, I quickly tested the patch and
works here, so it seems fine to me.
Comment 3 Michael Catanzaro 2018-05-21 08:29:28 PDT 
Ping reviewers
Comment 4 Michael Catanzaro 2018-05-23 10:50:51 PDT 
Committed r232118: <https://trac.webkit.org/changeset/232118>