Bug 185550 – Add referrerpolicy attribute support for <script> elements

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Dominic Farolino]

The HTML Standard PR [1] is adding support for the referrerpolicy attribute on <script> elements. Check the PR for a link to the relevant WPTs (which atm, I have not yet started).

[1]: https://github.com/whatwg/html/pull/3678

[Rob Buis]

Created attachment 370716 [details]
Patch

[Rob Buis]

Created attachment 370751 [details]
Patch

[EWS Watchlist]

Comment on attachment 370751 [details]
Patch

Attachment 370751 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12309031

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 370759 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 370751 [details]
Patch

Attachment 370751 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12309057

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 370761 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 370751 [details]
Patch

Attachment 370751 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12309032

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 370765 [details]
Archive of layout-test-results from ews115 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 370751 [details]
Patch

Attachment 370751 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12309335

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 370768 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[EWS Watchlist]

Comment on attachment 370751 [details]
Patch

Attachment 370751 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12309772

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 370772 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Rob Buis]

Created attachment 370833 [details]
Patch

[Rob Buis]

Created attachment 370835 [details]
Patch

[Rob Buis]

Created attachment 370870 [details]
Patch

[Rob Buis]

Created attachment 370878 [details]
Patch

[EWS Watchlist]

Comment on attachment 370878 [details]
Patch

Attachment 370878 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12321257

New failing tests:
http/tests/referrer-policy-script/origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/no-referrer-when-downgrade/cross-origin-http.https.html
http/tests/referrer-policy-script/same-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/unsafe-url/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http.https.html

[EWS Watchlist]

Created attachment 370884 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 370878 [details]
Patch

Attachment 370878 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12321279

New failing tests:
http/tests/referrer-policy-script/same-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https.html

[EWS Watchlist]

Created attachment 370886 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 370878 [details]
Patch

Attachment 370878 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12321345

New failing tests:
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/no-referrer-when-downgrade/cross-origin-http.https.html
http/tests/referrer-policy-script/origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https.html

[EWS Watchlist]

Created attachment 370889 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[EWS Watchlist]

Comment on attachment 370878 [details]
Patch

Attachment 370878 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12321635

New failing tests:
http/tests/referrer-policy-script/origin/same-origin.html
http/tests/referrer-policy-script/no-referrer/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/origin/cross-origin-http-http.html
http/tests/referrer-policy-script/origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin/same-origin.html
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/no-referrer-when-downgrade/cross-origin-http.https.html
http/tests/referrer-policy-script/same-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/no-referrer/cross-origin-http-http.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/unsafe-url/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https.html

[EWS Watchlist]

Created attachment 370892 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[EWS Watchlist]

Comment on attachment 370878 [details]
Patch

Attachment 370878 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12324173

New failing tests:
http/tests/referrer-policy-script/origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/same-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/unsafe-url/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https.html

[EWS Watchlist]

Created attachment 370918 [details]
Archive of layout-test-results from ews116 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Rob Buis]

Created attachment 370926 [details]
Patch

[EWS Watchlist]

Comment on attachment 370926 [details]
Patch

Attachment 370926 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12326139

New failing tests:
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https.html

[EWS Watchlist]

Created attachment 370928 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 370926 [details]
Patch

Attachment 370926 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12326214

New failing tests:
http/tests/referrer-policy-script/same-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https.html

[EWS Watchlist]

Created attachment 370931 [details]
Archive of layout-test-results from ews116 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Rob Buis]

Created attachment 370933 [details]
Patch

[EWS Watchlist]

Comment on attachment 370933 [details]
Patch

Attachment 370933 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12327053

New failing tests:
http/tests/referrer-policy-script/origin/same-origin.html
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/origin/cross-origin-http-http.html
http/tests/referrer-policy-script/strict-origin/same-origin.html
http/tests/referrer-policy-script/same-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/no-referrer/cross-origin-http-http.html
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https.html

[EWS Watchlist]

Created attachment 370936 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Rob Buis]

Created attachment 370939 [details]
Patch

[youenn fablet]

Comment on attachment 370939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370939&action=review

> Source/WebCore/ChangeLog:36
> +               http/tests/referrer-policy-script/unsafe-url/same-origin.html

Nice to have all these tests. I guess I should finish the reimport of WPT referrer policy tests.
I wonder whether some of these might be redundant though or would be worth exporting to WPT.

> Source/WebCore/bindings/js/CachedScriptFetcher.h:45
> +    CachedScriptFetcher(const String& nonce, const ReferrerPolicy& referrerPolicy, const String& charset, const AtomicString& initiatorName, bool isInUserAgentShadowTree)

s/const ReferrerPolicy& policy/ReferrerPolicy

> Source/WebCore/dom/LoadableClassicScript.cpp:38
> +Ref<LoadableClassicScript> LoadableClassicScript::create(const String& nonce, const String& integrityMetadata, const ReferrerPolicy& policy, const String& crossOriginMode, const String& charset, const AtomicString& initiatorName, bool isInUserAgentShadowTree)

Ditto, below as well

> LayoutTests/platform/win/TestExpectations:4299
> +webkit.org/b/195461 http/tests/referrer-policy-script [ Skip ]

Do we know why they are failing here?
I would have thought they would be similar to Mac-wk1.

[Rob Buis]

Created attachment 374201 [details]
Patch

[Rob Buis]

Created attachment 374204 [details]
Patch

[Rob Buis]

Comment on attachment 370939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370939&action=review

>> Source/WebCore/ChangeLog:36
>> +               http/tests/referrer-policy-script/unsafe-url/same-origin.html
> 
> Nice to have all these tests. I guess I should finish the reimport of WPT referrer policy tests.
> I wonder whether some of these might be redundant though or would be worth exporting to WPT.

It would be great to have the WPT referrer policy tests imported and working.
I think the http/tests/referrer-policy-script tests can be removed once that is done, since the WPT tests are even more in depth (same/cross origin, redirects etc.)

>> Source/WebCore/bindings/js/CachedScriptFetcher.h:45
>> +    CachedScriptFetcher(const String& nonce, const ReferrerPolicy& referrerPolicy, const String& charset, const AtomicString& initiatorName, bool isInUserAgentShadowTree)
> 
> s/const ReferrerPolicy& policy/ReferrerPolicy

I did this substitution everywhere in the patch.

>> Source/WebCore/dom/LoadableClassicScript.cpp:38
>> +Ref<LoadableClassicScript> LoadableClassicScript::create(const String& nonce, const String& integrityMetadata, const ReferrerPolicy& policy, const String& crossOriginMode, const String& charset, const AtomicString& initiatorName, bool isInUserAgentShadowTree)
> 
> Ditto, below as well

I did this substitution everywhere in the patch.

>> LayoutTests/platform/win/TestExpectations:4299
>> +webkit.org/b/195461 http/tests/referrer-policy-script [ Skip ]
> 
> Do we know why they are failing here?
> I would have thought they would be similar to Mac-wk1.

I think I read some bug report stating a lot of loading test started failing on win after some "framework" was removed or updated, but I can't find that bug.

[WebKit Commit Bot]

Comment on attachment 374204 [details]
Patch

Clearing flags on attachment: 374204

Committed r247509: <https://trac.webkit.org/changeset/247509>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53193901>