Bug 185542 - Network process should not stat() all cache files on startup to find their sizes
Summary: Network process should not stat() all cache files on startup to find their sizes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-11 00:38 PDT by Antti Koivisto
Modified: 2018-05-11 11:11 PDT (History)
5 users (show)

See Also:

Attachments
patch (5.58 KB, patch)
2018-05-11 01:14 PDT, Antti Koivisto 		cdumez: review+
Details | Formatted Diff | Diff
patch (5.58 KB, patch)
2018-05-11 10:32 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-05-11 00:38:45 PDT 
We can estimate the records sizes to avoid lots of CPU use and I/O under stat().
Comment 1 Antti Koivisto 2018-05-11 00:39:50 PDT 
<rdar://problem/40092953>
Comment 2 Antti Koivisto 2018-05-11 01:14:07 PDT 
Created attachment 340178 [details]
patch
Comment 3 Chris Dumez 2018-05-11 10:27:32 PDT 
Comment on attachment 340178 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340178&action=review

> Source/WebKit/ChangeLog:12
> +        Large bodies are saved in seprate blob files so record file sizes are capped. We can avoid work by

typo: seprate
Comment 4 Antti Koivisto 2018-05-11 10:32:54 PDT 
Created attachment 340197 [details]
patch
Comment 5 WebKit Commit Bot 2018-05-11 11:11:27 PDT 
Comment on attachment 340197 [details]
patch

Clearing flags on attachment: 340197

Committed r231708: <https://trac.webkit.org/changeset/231708>
Comment 6 WebKit Commit Bot 2018-05-11 11:11:29 PDT 
All reviewed patches have been landed.  Closing bug.