RESOLVED FIXED 185541
[JSC] Tweak LiteralParser to improve lexing performance 
https://bugs.webkit.org/show_bug.cgi?id=185541
Summary [JSC] Tweak LiteralParser to improve lexing performance
Yusuke Suzuki
Reported 2018-05-10 22:49:15 PDT
[JSC] Tweak LiteralParser to improve lexing performance
Attachments
Patch (29.75 KB, patch)
2018-05-10 22:54 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-10 22:54:58 PDT
Created attachment 340172 [details] Patch
Saam Barati
Comment 2 2018-05-14 09:13:30 PDT
Comment on attachment 340172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340172&action=review r=me > Source/JavaScriptCore/runtime/LiteralParser.cpp:501 > + default: Maybe add a debug assert of what the token types are here just for documentation?
Yusuke Suzuki
Comment 3 2018-05-14 09:41:04 PDT
Comment on attachment 340172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340172&action=review Thanks! >> Source/JavaScriptCore/runtime/LiteralParser.cpp:501 >> + default: > > Maybe add a debug assert of what the token types are here just for documentation? This is everything else... I've added them.
Yusuke Suzuki
Comment 4 2018-05-14 09:47:45 PDT
Committed r231761: <https://trac.webkit.org/changeset/231761>
Radar WebKit Bug Importer
Comment 5 2018-05-14 09:48:18 PDT
<rdar://problem/40220708>
Yusuke Suzuki
Comment 6 2018-05-14 11:32:18 PDT
The effect seems a bit small compared to my local environment, but it seems improved :) https://arewefastyet.com/#machine=29&view=single&suite=kraken&subtest=parse-financial
Note You need to log in before you can comment on or make changes to this bug.