Bug 185541 - [JSC] Tweak LiteralParser to improve lexing performance
Summary: [JSC] Tweak LiteralParser to improve lexing performance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-10 22:49 PDT by Yusuke Suzuki
Modified: 2018-05-14 11:32 PDT (History)
9 users (show)

See Also:


Attachments
Patch (29.75 KB, patch)
2018-05-10 22:54 PDT, Yusuke Suzuki
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-05-10 22:49:15 PDT
[JSC] Tweak LiteralParser to improve lexing performance
Comment 1 Yusuke Suzuki 2018-05-10 22:54:58 PDT
Created attachment 340172 [details]
Patch
Comment 2 Saam Barati 2018-05-14 09:13:30 PDT
Comment on attachment 340172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340172&action=review

r=me

> Source/JavaScriptCore/runtime/LiteralParser.cpp:501
> +        default:

Maybe add a debug assert of what the token types are here just for documentation?
Comment 3 Yusuke Suzuki 2018-05-14 09:41:04 PDT
Comment on attachment 340172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340172&action=review

Thanks!

>> Source/JavaScriptCore/runtime/LiteralParser.cpp:501
>> +        default:
> 
> Maybe add a debug assert of what the token types are here just for documentation?

This is everything else... I've added them.
Comment 4 Yusuke Suzuki 2018-05-14 09:47:45 PDT
Committed r231761: <https://trac.webkit.org/changeset/231761>
Comment 5 Radar WebKit Bug Importer 2018-05-14 09:48:18 PDT
<rdar://problem/40220708>
Comment 6 Yusuke Suzuki 2018-05-14 11:32:18 PDT
The effect seems a bit small compared to my local environment, but it seems improved :)
https://arewefastyet.com/#machine=29&view=single&suite=kraken&subtest=parse-financial