Experimental Storage Access API prompting is added in https://bugs.webkit.org/show_bug.cgi?id=185335. We should consider explicit user opt-in equivalent to user interaction as first party and thus extend the life time of cookies and website data.
<rdar://problem/40064547>
Created attachment 340146 [details] Patch
Comment on attachment 340146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340146&action=review > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=185534 <rdar://problem/40064547> > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:466 > + if (userWasPromptedNowOrEarlier && m_storageAccessPromptsEnabled) { Is it possible to have "userWasPromptedNowEarlier" be true, but 'm_storageAccessPromptsEnabled' is false? It doesn't seem like this code needs to know the state of the prompts being enabled -- if we get an update that says the prompt was accepted, we can just extend the lifetime of the cookie.
Comment on attachment 340146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340146&action=review >> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:466 >> + if (userWasPromptedNowOrEarlier && m_storageAccessPromptsEnabled) { > > Is it possible to have "userWasPromptedNowEarlier" be true, but 'm_storageAccessPromptsEnabled' is false? It doesn't seem like this code needs to know the state of the prompts being enabled -- if we get an update that says the prompt was accepted, we can just extend the lifetime of the cookie. Oh I get it. The tests won't work properly if we don't check for the experimental feature. Can you just add a FIXME here to remove this code once if we decide to use prompting for Storage Access API?
Comment on attachment 340146 [details] Patch r=me if EWS passes, and if you add the FIXME (with radar/bugzilla)
Created attachment 340154 [details] Patch for landing
Thanks, Brent!
Comment on attachment 340154 [details] Patch for landing Clearing flags on attachment: 340154 Committed r231684: <https://trac.webkit.org/changeset/231684>
All reviewed patches have been landed. Closing bug.